Revert changes to CODEOWNERS that caused build failure notifications to be routed to wrong people + assorted fixes
#33826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
requested review from
jsquire and
ronniegeraghty
as code owners
konrad-jamrozik
commented
Feb 1, 2023
konrad-jamrozik
commented
Feb 1, 2023
weshaggard
reviewed
Feb 2, 2023
weshaggard
reviewed
Feb 2, 2023
weshaggard
reviewed
Feb 2, 2023
konrad-jamrozik
commented
Feb 2, 2023
konrad-jamrozik
commented
Feb 2, 2023
This was referenced Feb 2, 2023
weshaggard
approved these changes
Feb 3, 2023
Contributor
Author
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I've been cleaning up
CODEOWNERSpaths:/sdk/<dir>rules #33597/**/ci.ymland/**/tests.yml#33595And also enabled the new regex-based wildcard-supporting
CODEOWNERSpath matcher:azure-sdk-for-netrepo azure-sdk-tools#5241NotificationConfigurationpackage from20230119.1to20230127.4azure-sdk-tools#5240Unfortunately, this led to few issues, most notably build failure notifications being routed to wrong folks, as seen in this table:
I.e. for
PATHthe failures are currently routed toRIGHT OWNERSinstead ofLEFT OWNERS. This PR fixes that, by ensuring the failures are again routed toLEFT OWNERS.This PR also restores paths for
/**/ci.ymland/**/tests.yml, and does few additional fixups, including aligning all owner lists.I am going to make a separate PR updating
iotand other ownership information based on discussion I had over email with @jsquire and other folks.