Update SDK based on examples changes to swagger spec by nathannfan · Pull Request #2847 · Azure/azure-sdk-for-net

nathannfan · 2017-02-22T19:44:45Z

Description

Swagger spec pull request: Azure/azure-rest-api-specs#954

This change updated the auto-generated SDK based on changes to the swagger spec that were done in response to examples validation and Fiddler testing.

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

…lastic pool crud, operation status, usages, and firewall rules

…instead of using hardcoded values in tests, other minor non-functional changes

…dings

azurecla · 2017-02-22T19:44:55Z

Hi @nathannfan, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (nafan). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

nathannfan · 2017-02-24T02:15:12Z

+            string testName = this.GetType().FullName;
+            SqlManagementTestUtilities.RunTestInNewV12Server(testName, "TestDatabasePointInTimeRestore", testPrefix, (resClient, sqlClient, resourceGroup, server) =>
+            {
+                Dictionary<string, string> tags = new Dictionary<string, string>()


Remove this

jaredmoo · 2017-02-24T18:46:07Z

+                activity = sqlClient.ElasticPools.ListDatabaseActivity(resourceGroup.Name, server.Name, epName2);
+                Assert.Equal(2, activity.Where(a => a.DatabaseName == dbName).Count());
+                Assert.Equal(1, activity.Where(a => a.DatabaseName == dbName && a.Operation == "CREATE").Count());
+                Assert.Equal(1, activity.Where(a => a.DatabaseName == dbName && a.Operation == "UPDATE").Count());


Can you also test removing the database from the pool?

jaredmoo

Looks great, I would just like to see a test to remove db from pool.

… API, update test recordings

jaredmoo · 2017-02-25T01:18:23Z

Approved

shahabhijeet

What version of AutoRest used to generate code.
Was the latest version used.
Also I don't see name simplification was used during code generation.

shahabhijeet · 2017-02-26T01:30:52Z

                    throw new Microsoft.Rest.SerializationException("Unable to deserialize the response.", _responseContent, ex);
                }
            }
-            // Deserialize Response


@nathannfan did the swagger changed and is no longer returning 202?

Swagger still documents 202, but no longer has a response body, which I believe is why this section is removed.

shahabhijeet · 2017-02-26T01:31:57Z

        /// A response object containing the response body and response headers.
        /// </return>
-        public async System.Threading.Tasks.Task<Microsoft.Rest.Azure.AzureOperationResponse<System.Collections.Generic.IEnumerable<ElasticPoolDatabaseActivity>>> ListDatabaseActivityWithHttpMessagesAsync(string elasticPoolName, string resourceGroupName, string serverName, System.Collections.Generic.Dictionary<string, System.Collections.Generic.List<string>> customHeaders = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken))
+        public async System.Threading.Tasks.Task<Microsoft.Rest.Azure.AzureOperationResponse<System.Collections.Generic.IEnumerable<ElasticPoolDatabaseActivity>>> ListDatabaseActivityWithHttpMessagesAsync(string resourceGroupName, string serverName, string elasticPoolName, System.Collections.Generic.Dictionary<string, System.Collections.Generic.List<string>> customHeaders = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken))


@nathannfan was name simplification used when the code was generated via AutoRest?

@shahabhijeet Not sure how that is specified. Is there documentation?

Synced up with Cormac. This requires a later version of AutoRest.

cormacpayne · 2017-02-28T00:22:16Z

@azuresdkci test this please

shahabhijeet · 2017-02-28T04:20:36Z

@nathannfan starting next PR, please use the latest Autorest 1.0 to regen code. It's ok for this PR.

nathannfan added 12 commits October 22, 2016 17:05

Initial commit of client testing around Server crud, database crud, e…

92ab945

…lastic pool crud, operation status, usages, and firewall rules

Updated tests to match updated specs

36f9879

Update tests to reflect name changes in swagger spec

f4493b1

Responded to comments, added GeoDR functionality

a3484ca

Responded to comments, added GeoDR functionality

63bd3db

Updated test records

136d7f1

Additional test and recording fixes

5a32898

Merge remote-tracking branch 'upstream/AutoRest' into AutoRest

ec0d325

Update TestFramework version, re-do Test Recordings

f2756be

Responded to comments: updated comments, referenced constant classes …

656ec25

…instead of using hardcoded values in tests, other minor non-functional changes

Merge remote-tracking branch 'upstream/AutoRest' into AutoRest

7c1c45e

Re-generate code after Swagger examples update and fixes, re-do recor…

6645568

…dings

azurecla added the cla-not-required label Feb 22, 2017

nathannfan and others added 5 commits February 22, 2017 14:25

Merge remote-tracking branch 'upstream/AutoRest' into AutoRest

f7de0fe

Regen from Swagger. DB now has RestorePointInTime

2c6c703

Added point in time restore test

9fc86c3

Regen from swagger

1dfb310

Added SampleName param to DB create max test case

9efd1e4

nathannfan requested review from akromm-zz and jaredmoo February 24, 2017 02:12

nathannfan added 2 commits February 23, 2017 18:37

Added Copy and move db between pools scenarios

323cf27

Merge remote-tracking branch 'origin' into AutoRest

dbcc7b7

nathannfan commented Feb 24, 2017

View reviewed changes

nathannfan self-assigned this Feb 24, 2017

jaredmoo reviewed Feb 24, 2017

View reviewed changes

jaredmoo approved these changes Feb 24, 2017

View reviewed changes

nathannfan added 2 commits February 24, 2017 14:35

Update client to remove unused parameters/definitions, add Operations…

627bdf2

… API, update test recordings

Add test case for removing database from elastic pool

6d9709c

nathannfan removed the request for review from akromm-zz February 25, 2017 01:21

shahabhijeet suggested changes Feb 26, 2017

View reviewed changes

shahabhijeet added the Changes Requested label Feb 26, 2017

jaredmoo added 2 commits February 27, 2017 14:04

Regen with doc updates

b67c487

Added test for list database filter

071fd65

jaredmoo mentioned this pull request Feb 27, 2017

Added $filter param to list databases Azure/azure-rest-api-specs#973

Merged

10 tasks

Update AutoRest to 1.0.0-Nightly20161212 and regen

1b479a6

shahabhijeet removed the Changes Requested label Feb 28, 2017

shahabhijeet approved these changes Feb 28, 2017

View reviewed changes

shahabhijeet merged commit 55c8ea6 into Azure:AutoRest Feb 28, 2017

Conversation

nathannfan commented Feb 22, 2017

Description

This change updated the auto-generated SDK based on changes to the swagger spec that were done in response to examples validation and Fiddler testing.

Uh oh!

azurecla commented Feb 22, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredmoo left a comment

Choose a reason for hiding this comment

Uh oh!

jaredmoo commented Feb 25, 2017

Uh oh!

shahabhijeet left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Feb 28, 2017

Uh oh!

shahabhijeet commented Feb 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants