Skip to content

Added $filter param to list databases#973

Merged
amarzavery merged 3 commits intoAzure:masterfrom
jaredmoo:dbfilter
Mar 1, 2017
Merged

Added $filter param to list databases#973
amarzavery merged 3 commits intoAzure:masterfrom
jaredmoo:dbfilter

Conversation

@jaredmoo
Copy link
Copy Markdown
Contributor

@jaredmoo jaredmoo commented Feb 27, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

  • I have read the contribution guidelines.
  • My spec meets the review criteria:
    • The spec conforms to the Swagger 2.0 specification.
    • Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
    • The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

@azurecla
Copy link
Copy Markdown

Hi @jaredmoo, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (jaredmoo). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@jaredmoo
Copy link
Copy Markdown
Contributor Author

New test case is in Azure/azure-sdk-for-net#2847

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Feb 28, 2017

LGTM. @olydis just curious, renaming the enum should not be a breaking change correct? I know it isn't for C# but not sure about others.
Also, feel free to merge

@jaredmoo
Copy link
Copy Markdown
Contributor Author

jaredmoo commented Mar 1, 2017

Can I get a merge here please?

@AutorestCI
Copy link
Copy Markdown

@AutorestCI
Copy link
Copy Markdown

No modification for NodeJS

@AutorestCI
Copy link
Copy Markdown

@jaredmoo
Copy link
Copy Markdown
Contributor Author

jaredmoo commented Mar 1, 2017

Thanks!

@jaredmoo jaredmoo deleted the dbfilter branch March 1, 2017 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants