Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormRecognizer] Updated Form Recognizer sanitized properties #28151

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

kinelski
Copy link
Member

Long story short, this is the timeline of events that caused the bug we're fixing in this PR:

  • Test Framework introduces a bug that prevents tests from correctly finding mismatches in Playback mode.
  • A miscopy updates the FR live test base constructor, sanitizing the wrong property. This would make tests fail, but this goes undetected because of the Test Framework bug.
  • The Test Framework bug is detected and fixed. The FR bug is exposed.
  • We're fixing the FR bug now.

Fixes #27701.

@azure-sdk
Copy link
Collaborator

API change check for Azure.AI.FormRecognizer

API changes are not detected in this pull request for Azure.AI.FormRecognizer

@kinelski kinelski marked this pull request as ready for review April 11, 2022 17:45
@kinelski kinelski added the Client This issue points to a problem in the data-plane of the library. label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FormRecognizer] Investigate tests that were able to pass based on CompareBodies bug
3 participants