Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Need to investigate tests that were able to pass based on CompareBodies bug #27688

Closed
JoshLove-msft opened this issue Mar 22, 2022 · 2 comments
Closed

[BUG] Need to investigate tests that were able to pass based on CompareBodies bug #27688

JoshLove-msft opened this issue Mar 22, 2022 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault Synapse
Milestone
Backlog

Comments

@JoshLove-msft
Copy link
Member

JoshLove-msft commented Mar 22, 2022 •
edited
Loading

The default value of CompareBodies was inadvertently changed from true to false in 96fc90a.

As a result, some tests have been recorded between the time that was merged and now, that no longer pass when fixing the bug.
The tests are in Key Vault, Form Recognizer, and Synapse.
In order to prevent more broken tests from being recorded I am going to flip back the value and set CompareBodies to false in these specific libraries. This issue will track the work needed to investigate and fix the affected tests.
@JoshLove-msft JoshLove-msft added KeyVault Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer labels Mar 22, 2022
@JoshLove-msft
Copy link
Member Author

Found while working on #27687

@JoshLove-msft JoshLove-msft changed the title [BUG] Need to re-record tests that were able to pass based on CompareBodies bug [BUG] Need to investigate tests that were able to pass based on CompareBodies bug Mar 22, 2022
@heaths heaths mentioned this issue Mar 22, 2022
Closed
@kinelski kinelski mentioned this issue Mar 22, 2022
Closed
@kinelski
Copy link
Member

The Form Recognizer part has been fixed (#28151).

@heaths heaths added this to the Backlog milestone Oct 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault Synapse
Projects
Azure SDK for Key Vault
Archived in project
Milestone
Backlog
Development

No branches or pull requests
4 participants
@heaths @kinelski @pallavit @JoshLove-msft