Regenerated WebSites SDK for January 2017 release by nking-1 · Pull Request #2763 · Azure/azure-sdk-for-net

nking-1 · 2017-01-27T22:55:51Z

Description

Regenerated the WebSites SDK from Swagger spec. Link to Swagger PR:
Azure/azure-rest-api-specs#878
Azure/azure-rest-api-specs#881

The SDK version has been bumped because of potential breaking changes.

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

azurecla · 2017-01-27T22:56:12Z

Hi @Nking92, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (nicking). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

cormacpayne

@Nking92 Hey Nick, I left a dozen or so comments.

The comments about "removal of default parameters" or "ordering has changed for parameters in the constructor" applies to a lot of the model classes, so I stopped leaving the comment after the first few files so it didn't litter the review.
Since the Websites SDK is still in preview, these breaking changes should be fine to accept, but you will need to mitigate these changes if you do decide to make any changes in PowerShell

cormacpayne · 2017-01-30T18:10:52Z

src/ResourceManagement/WebSite/Microsoft.Azure.Management.Websites/Generated/Models/Address.cs

+        /// <param name="postalCode">Postal code.</param>
+        /// <param name="state">State.</param>
+        /// <param name="address2">Address 2.</param>
+        public Address(string address1, string city, string country, string postalCode, string state, string address2 = default(string))


@Nking92 breaking change - some default values were removed, and the ordering of the parameters have changed

We changed some of these parameters to be required since our REST API actually rejects null values here

cormacpayne · 2017-01-30T18:12:53Z

...gement/WebSite/Microsoft.Azure.Management.Websites/Generated/Models/AppServiceCertificate.cs

+        /// 'AzureServiceUnauthorizedToAccessKeyVault', 'KeyVaultDoesNotExist',
+        /// 'KeyVaultSecretDoesNotExist', 'UnknownError', 'ExternalPrivateKey',
+        /// 'Unknown'</param>
+        public AppServiceCertificate(string location, string id = default(string), string name = default(string), string kind = default(string), string type = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), string keyVaultId = default(string), string keyVaultSecretName = default(string), KeyVaultSecretStatus? provisioningState = default(KeyVaultSecretStatus?))


@Nking92 breaking change - the ordering of the parameters has changed

cormacpayne · 2017-01-30T18:14:02Z

...t/WebSite/Microsoft.Azure.Management.Websites/Generated/Models/AppServiceCertificateOrder.cs

+        /// <param name="isPrivateKeyExternal">&lt;code&gt;true&lt;/code&gt; if
+        /// private key is external; otherwise,
+        /// &lt;code&gt;false&lt;/code&gt;.</param>
+        public AppServiceCertificateOrder(string location, string id = default(string), string name = default(string), string kind = default(string), string type = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IDictionary<string, AppServiceCertificate> certificates = default(IDictionary<string, AppServiceCertificate>), string distinguishedName = default(string), string domainVerificationToken = default(string), int? validityInYears = default(int?), int? keySize = default(int?), CertificateProductType? productType = default(CertificateProductType?), bool? autoRenew = default(bool?), ProvisioningState? provisioningState = default(ProvisioningState?), CertificateOrderStatus? status = default(CertificateOrderStatus?), CertificateDetails signedCertificate = default(CertificateDetails), string csr = default(string), CertificateDetails intermediate = default(CertificateDetails), CertificateDetails root = default(CertificateDetails), string serialNumber = default(string), System.DateTime? lastCertificateIssuanceTime = default(System.DateTime?), System.DateTime? expirationTime = default(System.DateTime?), bool? isPrivateKeyExternal = default(bool?))


@Nking92 breaking change - ordering of parameters has changed

cormacpayne · 2017-01-30T18:29:18Z

src/ResourceManagement/WebSite/Microsoft.Azure.Management.Websites/Generated/Models/ArmPlan.cs

@@ -1,72 +0,0 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.


@Nking92 breaking change - removal of the entire file

cormacpayne · 2017-01-30T18:34:10Z

...rceManagement/WebSite/Microsoft.Azure.Management.Websites/Generated/Models/BackupSchedule.cs

        /// </summary>
        [JsonProperty(PropertyName = "frequencyInterval")]
-        public int? FrequencyInterval { get; set; }
+        public int FrequencyInterval { get; set; }


@Nking92 breaking change - null is no longer an accepted value for this property

This is a required property, so we'll add a default non-null value here

cormacpayne · 2017-01-30T18:51:19Z

...anagement/WebSite/Microsoft.Azure.Management.Websites/Generated/Models/RecommendationRule.cs

-        /// On/off flag indicating the rule is currently enabled or disabled.
-        /// </summary>
-        [JsonProperty(PropertyName = "enabled")]
-        public int? Enabled { get; set; }


@Nking92 breaking change - removal of property

cormacpayne · 2017-01-30T18:53:31Z

...eManagement/WebSite/Microsoft.Azure.Management.Websites/Generated/Models/SiteAuthSettings.cs

        /// </summary>
-        [JsonProperty(PropertyName = "httpApiPrefixPath")]
-        public string HttpApiPrefixPath { get; set; }


@Nking92 breaking change - removal of property

cormacpayne · 2017-01-30T18:53:58Z

...eManagement/WebSite/Microsoft.Azure.Management.Websites/Generated/Models/SiteAuthSettings.cs

-        /// <summary>
-        /// </summary>
-        [JsonProperty(PropertyName = "openIdIssuer")]
-        public string OpenIdIssuer { get; set; }


@Nking92 same comment for AadClientId and OpenIdIssuer

cormacpayne · 2017-01-30T18:58:25Z

...anagement/WebSite/Microsoft.Azure.Management.Websites/Generated/Models/ValidateProperties.cs

@@ -1,66 +0,0 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.


@Nking92 breaking change - removal of file

cormacpayne · 2017-01-30T18:58:52Z

...ceManagement/WebSite/Microsoft.Azure.Management.Websites/Generated/Models/ValidateRequest.cs

        /// </summary>
-        [JsonProperty(PropertyName = "properties")]
-        public ValidateProperties Properties { get; set; }


@Nking92 breaking change - removal of property

nking-1 · 2017-01-30T20:08:49Z

After discussing the review comments with @naveedaz we've decided to keep the breaking changes.

The BackupSchedule properties that were previously nullable will have default values added soon. I've filed an issue for it. We'd like to not block this SDK update on fixing that small bug, and instead fix it in a smaller PR.

cormacpayne · 2017-02-03T00:53:06Z

LGTM

Regenerated WebSites SDK for January 2017 release

b8569fa

azurecla added the cla-not-required label Jan 27, 2017

Fixing DateTime time zone issue in GetSiteMetrics test

41c0af9

nking-1 requested review from amarzavery, fearthecowboy and hovsepm January 28, 2017 00:58

cormacpayne reviewed Jan 30, 2017

View reviewed changes

nking-1 requested a review from markcowl February 1, 2017 22:39

cormacpayne merged commit dbbf097 into Azure:AutoRest Feb 3, 2017

		@@ -1,72 +0,0 @@
		// Copyright (c) Microsoft Corporation. All rights reserved.

		@@ -1,66 +0,0 @@
		// Copyright (c) Microsoft Corporation. All rights reserved.

Conversation

nking-1 commented Jan 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

azurecla commented Jan 27, 2017

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nking-1 commented Jan 30, 2017

Uh oh!

cormacpayne commented Feb 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nking-1 commented Jan 27, 2017 •

edited

Loading