Skip to content

Update WebApps AppServicePlans: Fix delete response code, add ScmType…#881

Merged
fearthecowboy merged 2 commits intoAzure:masterfrom
nking-1:master
Jan 27, 2017
Merged

Update WebApps AppServicePlans: Fix delete response code, add ScmType…#881
fearthecowboy merged 2 commits intoAzure:masterfrom
nking-1:master

Conversation

@nking-1
Copy link
Copy Markdown

@nking-1 nking-1 commented Jan 26, 2017

… enum, add linuxFxVersion property

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

  • I have read the contribution guidelines.
  • My spec meets the review criteria:
    • The spec conforms to the Swagger 2.0 specification.
    • Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
    • The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

@azurecla
Copy link
Copy Markdown

Hi @Nking92, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (nicking). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nking-1
Copy link
Copy Markdown
Author

nking-1 commented Jan 26, 2017

We noticed there are a couple of other files that need updating. Added them to this PR. The changes are basically the same across all files.

@fearthecowboy fearthecowboy merged commit 5214740 into Azure:master Jan 27, 2017
@AutorestCI
Copy link
Copy Markdown

No modification for Ruby

@AutorestCI
Copy link
Copy Markdown

No modification for Python

@AutorestCI
Copy link
Copy Markdown

No modification for NodeJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants