Update codeowners by AlexGhiondea · Pull Request #15869 · Azure/azure-sdk-for-net

AlexGhiondea · 2020-10-12T17:08:15Z

No description provided.

AlexGhiondea · 2020-10-15T23:37:04Z

Azure.Core is not the right one for this one.

Ah okay my bad - we can leave it as NotInRepo instead then

AlexGhiondea · 2020-10-15T23:37:53Z

This one might just be for the resource manager for Cosmos... not for all of Cosmos... We should ask

AlexGhiondea · 2020-10-15T23:38:48Z

This folder only contains the resource manager for network... That might be the right thing -- but not 100% sure.

weshaggard · 2020-10-20T17:17:37Z

I'd consider removing %Service Attention duplication in this file and have the tool that sets up the rule add this label automatically.

Talked about this offline -- we'll leave this in for now.

weshaggard

Made one comment but otherwise looks good.

… merge conflicts.

added some more folders to service labels I found

Update 2 owners.

Update the ARM - Core entry to not point to Azure.Core

Doing this so that we reduce the amount of comments in the file which could lead to confusion.

Add the Event Hubs, Event Grid and Service Bus owners.

Update Event Hubs CODEOWNER

jsquire · 2020-10-23T13:06:17Z

@AlexGhiondea: You may want to consider pulling in the additions from #16200 and #16189

jsquire · 2020-10-23T13:10:12Z

+
+# ######## Management Plane ########
+
+/**/*Management*/                               @allenjzhang @m-nash @markcowl @YalinLi0312 @bquantump @nisha-bhatia


This one is broad and catches things like changes to sdk/servicebus/Azure.Messaging.ServiceBus/tests/Administration/ServiceBusManagementClientLiveTests.cs. I don't have a good suggestion for tuning it, but maybe you do?

I will leave that as-is for now... this particular one is only used for the PR owner suggestions.

AlexGhiondea · 2020-10-23T20:01:59Z

/check-enforcer override

jsquire · 2020-10-30T14:05:56Z

@AlexGhiondea: You'll likely want to absorb the additions from ##16440 as well.

Update EventGrid.

Fix issue with the PR Label.

Incorporate Azure#16200

Incorporate Azure#16363

Incorporate Azure#16440

AlexGhiondea · 2020-11-03T19:27:01Z

/check-enforcer override

check-enforcer · 2020-11-03T19:32:02Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

Ensure that for WebJobs we label PRs.

Clarify the storage section.

drwill-ms · 2020-11-03T20:05:45Z

 # PRLabel: %DigitalTwins
-/sdk/digitaltwins/                              @drwill-ms @timtay-microsoft @abhipsaMisra @vinagesh @azabbasi @bikamani @barustum @jamdavi
+# ServiceLabel: %Digital Twins %Service Attention
+/sdk/digitaltwins/                              @drwill-ms @timtay-microsoft @abhipsaMisra @vinagesh @azabbasi @bikamani @barustum @sourabhguha @inesk-vt @jamdavi


Why did @sourabhguha and @inesk-vt get added? I'm not against it, but noticing this is a change. They may not want all the PR email.

This comes from the internal wiki list. I will add them there for now and if there is too much traffic we can remove.

I checked with Saurabh, and he asked me to remove him. I'm checking with Ines.

Is there any benefit to them to be on this list, aside from PR participation?

Remove person not on the team anymore.

AlexGhiondea · 2020-11-03T21:36:11Z

/check-enforcer override

* Add codeowners to the file * Add more changes to the codeowners file. * Re-arrange codeowners file * Move the Management and EngSys sections to the top of the file. * Remove angled brackets from the file to not make it look like we have merge conflicts. * Update CODEOWNERS added some more folders to service labels I found * Update CODEOWNERS Update 2 owners. * Update CODEOWNERS Update the ARM - Core entry to not point to Azure.Core * Remove the extra comment around the actual entries Doing this so that we reduce the amount of comments in the file which could lead to confusion. * Update CODEOWNERS Add the Event Hubs, Event Grid and Service Bus owners. * Update CODEOWNERS Update Event Hubs CODEOWNER * Update CODEOWNERS Update EventGrid. * Update CODEOWNERS Fix issue with the PR Label. * Update CODEOWNERS Incorporate Azure#16200 * Update CODEOWNERS Incorporate Azure#16363 * Update CODEOWNERS Incorporate Azure#16440 * Update CODEOWNERS Ensure that for WebJobs we label PRs. * Update CODEOWNERS Clarify the storage section. * Update CODEOWNERS Remove person not on the team anymore. Co-authored-by: Meera Haridasa <22649188+meeraharidasa@users.noreply.github.com>

AlexGhiondea requested a review from weshaggard October 12, 2020 17:08

weshaggard reviewed Oct 12, 2020

View reviewed changes

Comment thread .github/CODEOWNERS Outdated

weshaggard reviewed Oct 12, 2020

View reviewed changes

Comment thread .github/CODEOWNERS Outdated

AlexGhiondea commented Oct 15, 2020

View reviewed changes

weshaggard reviewed Oct 20, 2020

View reviewed changes

weshaggard approved these changes Oct 20, 2020

View reviewed changes

AlexGhiondea and others added 9 commits October 20, 2020 10:58

Add codeowners to the file

7a4f0b6

Add more changes to the codeowners file.

9d8f401

Re-arrange codeowners file

a57571e

Move the Management and EngSys sections to the top of the file.

f609e20

Remove angled brackets from the file to not make it look like we have…

2aef255

… merge conflicts.

Update CODEOWNERS

51d7bf9

added some more folders to service labels I found

Update CODEOWNERS

59117a6

Update 2 owners.

Update CODEOWNERS

cd0bcb6

Update the ARM - Core entry to not point to Azure.Core

Remove the extra comment around the actual entries

f00d81a

Doing this so that we reduce the amount of comments in the file which could lead to confusion.

AlexGhiondea force-pushed the UpdateCodeowners branch from 3e07e9a to f00d81a Compare October 20, 2020 17:59

AlexGhiondea marked this pull request as ready for review October 20, 2020 18:00

AlexGhiondea added 2 commits October 21, 2020 10:30

Update CODEOWNERS

0a59e05

Add the Event Hubs, Event Grid and Service Bus owners.

Update CODEOWNERS

e87f7f5

Update Event Hubs CODEOWNER

weshaggard approved these changes Oct 22, 2020

View reviewed changes

joshfree approved these changes Oct 22, 2020

View reviewed changes

joshfree mentioned this pull request Oct 22, 2020

Ensure CODEOWNERS is the one source of truth for bot notifications to github users Azure/azure-sdk#1771

Closed

jsquire mentioned this pull request Oct 23, 2020

Update CODEOWNERS #16200

Merged

jsquire approved these changes Oct 23, 2020

View reviewed changes

kasobol-msft reviewed Oct 23, 2020

View reviewed changes

Comment thread .github/CODEOWNERS Outdated

AlexGhiondea added 6 commits November 3, 2020 11:11

Update CODEOWNERS

b2343f8

Update EventGrid.

Update CODEOWNERS

11ac111

Fix issue with the PR Label.

Update CODEOWNERS

f41549d

Incorporate Azure#16200

Update CODEOWNERS

a761f2b

Incorporate Azure#16363

Update CODEOWNERS

f5a8139

Incorporate Azure#16440

Merge branch 'master' into UpdateCodeowners

7220240

AlexGhiondea added 2 commits November 3, 2020 11:43

Update CODEOWNERS

53bc1be

Ensure that for WebJobs we label PRs.

Update CODEOWNERS

e327709

Clarify the storage section.

drwill-ms reviewed Nov 3, 2020

View reviewed changes

Comment thread .github/CODEOWNERS Outdated

Update CODEOWNERS

2e46c62

Remove person not on the team anymore.

AlexGhiondea merged commit 834641b into Azure:master Nov 3, 2020

rajkumar-rangaraj mentioned this pull request Nov 12, 2020

Update CODEOWNERS #16901

Merged

konrad-jamrozik mentioned this pull request Feb 2, 2023

Revert changes to CODEOWNERS that caused build failure notifications to be routed to wrong people + assorted fixes #33826

Merged


		# ######## Management Plane ########

		/*/Management*/ @allenjzhang @m-nash @markcowl @YalinLi0312 @bquantump @nisha-bhatia

Conversation

AlexGhiondea commented Oct 12, 2020

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weshaggard left a comment

Choose a reason for hiding this comment

Uh oh!

jsquire commented Oct 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexGhiondea commented Oct 23, 2020

Uh oh!

jsquire commented Oct 30, 2020

Uh oh!

AlexGhiondea commented Nov 3, 2020

Uh oh!

check-enforcer Bot commented Nov 3, 2020

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexGhiondea commented Nov 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jsquire commented Oct 23, 2020 •

edited

Loading