[Event Hubs] Canary support for live tests#15265
Merged
HarshaNalluru merged 4 commits intoAzure:masterfrom Sep 29, 2020
Merged
Conversation
ghost
added
the
HarshaNalluru
requested review from
chidozieononiwu,
mitchdenny and
weshaggard
as code owners
weshaggard
reviewed
Sep 25, 2020
weshaggard
approved these changes
Sep 25, 2020
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
One comment about switching to .NET Core but otherwise looks reasonable.
Member
|
@damirault please keep this change in mind while working on @danieljurek other PR. We should see how these two should be combined. |
weshaggard
approved these changes
Sep 26, 2020
Contributor
|
#15285 is the other PR @weshaggard is referencing. |
Contributor
Author
jsquire
approved these changes
Sep 29, 2020
Member
jsquire
left a comment
jsquire
left a comment
There was a problem hiding this comment.
LGTM. I've seen a few runs manually triggered in the past week and they seem to be coming back clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last triggered pipeline - https://dev.azure.com/azure-sdk/internal/_build/results?buildId=553341&view=results
More relevant info - Azure/azure-sdk-for-js#11318