[EventHubs] Canary support for event-hubs live tests#11318
Merged
HarshaNalluru merged 3 commits intoAzure:masterfrom Sep 29, 2020
Merged
[EventHubs] Canary support for event-hubs live tests#11318HarshaNalluru merged 3 commits intoAzure:masterfrom
HarshaNalluru merged 3 commits intoAzure:masterfrom
Conversation
ghost
added
the
HarshaNalluru
requested review from
KarishmaGhiya,
mikeharder,
mitchdenny and
weshaggard
as code owners
Contributor
|
Thanks @HarshaNalluru! @praveenkuttappan, @weshaggard Are we good with this approach for canary? |
weshaggard
reviewed
Sep 25, 2020
weshaggard
reviewed
Sep 25, 2020
weshaggard
approved these changes
Sep 25, 2020
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
I added a couple comments/questions but I'm good with this approach for now.
This was referenced Sep 25, 2020
This was referenced Sep 30, 2020
ghost
pushed a commit
that referenced
this pull request
Oct 2, 2020
Similar to what we did for event-hubs... #11318 Java - Azure/azure-sdk-for-java#15844 .NET - Azure/azure-sdk-for-net#15592
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last triggered pipeline - https://dev.azure.com/azure-sdk/internal/_build/results?buildId=552802&view=results
With this PR, our test subscription (preview) creates the event-hubs resources in the canary regions for testing ('Central US EUAP' and 'EAST US 2 EUAP' regions as suggested by the service team).
Many thanks to @danieljurek!!
JAVA - Azure/azure-sdk-for-java#15345
.NET - Azure/azure-sdk-for-net#15265