[StreamAnalytics] Update sdk to 2020-03-01-preview version#15198
Merged
allenjzhang merged 3 commits intoAzure:masterfrom Sep 22, 2020
Merged
[StreamAnalytics] Update sdk to 2020-03-01-preview version#15198allenjzhang merged 3 commits intoAzure:masterfrom
allenjzhang merged 3 commits intoAzure:masterfrom
Conversation
allenjzhang
suggested changes
Sep 16, 2020
Contributor
allenjzhang
left a comment
There was a problem hiding this comment.
Could you:
-
Check in the metadata TXT file generated when you run
generate.ps1(details) -
Update api tag in
AzSdk.RP.props, release notes in csproj -
Update versions in csproj and
assemblyinfo.csif you are going to release
Thanks
Contributor
Author
|
@allenjzhang addressed comments, could you help us to re-review that, thank you a lot. |
allenjzhang
suggested changes
Sep 18, 2020
Contributor
There was a problem hiding this comment.
Thank you for your recent update. Can you make two minor changes, and we will be all good.
- Update the version number in assemblyinfo.cs
- Add some meaning release notes in the csproj. They will show up front and center on nuget to give user context on the new release of libraries. It is particularly helpful since the major version has changed.
Contributor
Author
Thanks for your comments. Updated. |
Contributor
Author
|
@allenjzhang addressed comments, could you help us to re-review that, thank you a lot. |
allenjzhang
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swagger pr: Azure/azure-rest-api-specs#10673
tag: package-2020-03-preview