Skip to content

[StreamAnalytics] Update sdk to 2020-03-01-preview version#15198

Merged
allenjzhang merged 3 commits intoAzure:masterfrom
sunsw1994:asa-update-sdk
Sep 22, 2020
Merged

[StreamAnalytics] Update sdk to 2020-03-01-preview version#15198
allenjzhang merged 3 commits intoAzure:masterfrom
sunsw1994:asa-update-sdk

Conversation

@sunsw1994
Copy link
Copy Markdown
Contributor

swagger pr: Azure/azure-rest-api-specs#10673
tag: package-2020-03-preview

  1. Add missing features for ASA streaming job
  2. Add ASA cluster and private endpoint related sdk

@sunsw1994 sunsw1994 requested a review from idear1203 September 16, 2020 07:57
@sunsw1994 sunsw1994 changed the title [Streamanalytics] Update sdk to 2020-03-01-preview version [StreamAnalytics] Update sdk to 2020-03-01-preview version Sep 16, 2020
Copy link
Copy Markdown
Contributor

@allenjzhang allenjzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you:

  • Check in the metadata TXT file generated when you run generate.ps1(details)

  • Update api tag in AzSdk.RP.props, release notes in csproj

  • Update versions in csproj and assemblyinfo.cs if you are going to release

Thanks

@allenjzhang allenjzhang added Mgmt This issue is related to a management package. needs-revision labels Sep 16, 2020
@sunsw1994
Copy link
Copy Markdown
Contributor Author

@allenjzhang addressed comments, could you help us to re-review that, thank you a lot.

Copy link
Copy Markdown
Contributor

@allenjzhang allenjzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your recent update. Can you make two minor changes, and we will be all good.

  1. Update the version number in assemblyinfo.cs
  2. Add some meaning release notes in the csproj. They will show up front and center on nuget to give user context on the new release of libraries. It is particularly helpful since the major version has changed.

@sunsw1994
Copy link
Copy Markdown
Contributor Author

Thank you for your recent update. Can you make two minor changes, and we will be all good.

  1. Update the version number in assemblyinfo.cs
  2. Add some meaning release notes in the csproj. They will show up front and center on nuget to give user context on the new release of libraries. It is particularly helpful since the major version has changed.

Thanks for your comments. Updated.

@sunsw1994
Copy link
Copy Markdown
Contributor Author

@allenjzhang addressed comments, could you help us to re-review that, thank you a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants