Skip to content

Dev StreamAnalytics 2017-04-01-preview version for streaming job and 2020-03-01-preview version for dedicated cluster#10673

Merged
weidongxu-microsoft merged 12 commits intoAzure:masterfrom
sunsw1994:dev-streamanalytics-Microsoft.StreamAnalytics-2017-04-01-preview
Sep 11, 2020
Merged

Dev StreamAnalytics 2017-04-01-preview version for streaming job and 2020-03-01-preview version for dedicated cluster#10673
weidongxu-microsoft merged 12 commits intoAzure:masterfrom
sunsw1994:dev-streamanalytics-Microsoft.StreamAnalytics-2017-04-01-preview

Conversation

@sunsw1994
Copy link
Contributor

@sunsw1994 sunsw1994 commented Sep 2, 2020

  • Add the 2017-04-01-preview folder and copy the 2016-03-01 files for streaming job related swaggers.
  • Add missing features for 2017-04-01-preview
  • Add 2020-03-01-preview version for ASA cluster and private endpoint

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 2, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 2, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 2, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 2, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 90b28d0 with merge commit ec2cba2. SDK Automation 13.0.17.20200909.5
  • ️✔️preview/streamanalytics/mgmt/2020-03-01-preview [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 11 Sep 2020 09:18:51 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0780:22B1:60E46E:A1359C:5F5B40FB","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 2, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 2, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 90b28d0 with merge commit ec2cba2. SDK Automation 13.0.17.20200909.5
  • ️✔️@azure/arm-streamanalytics [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/streamAnalyticsManagementClient.js → ./dist/arm-streamanalytics.js...
    [npmPack] created ./dist/arm-streamanalytics.js in 522ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-streamanalytics@1.1.1
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 259.3kB dist/arm-streamanalytics.js                        
    [npmPack] npm notice 100.4kB dist/arm-streamanalytics.min.js                    
    [npmPack] npm notice 13.8kB  esm/operations/clusters.js                         
    [npmPack] npm notice 2.2kB   esm/models/clustersMappers.js                      
    [npmPack] npm notice 11.9kB  esm/operations/functions.js                        
    [npmPack] npm notice 2.6kB   esm/models/functionsMappers.js                     
    [npmPack] npm notice 345B    esm/models/index.js                                
    [npmPack] npm notice 628B    esm/operations/index.js                            
    [npmPack] npm notice 10.0kB  esm/operations/inputs.js                           
    [npmPack] npm notice 2.2kB   esm/models/inputsMappers.js                        
    [npmPack] npm notice 106.8kB esm/models/mappers.js                              
    [npmPack] npm notice 2.3kB   esm/operations/operations.js                       
    [npmPack] npm notice 471B    esm/models/operationsMappers.js                    
    [npmPack] npm notice 10.1kB  esm/operations/outputs.js                          
    [npmPack] npm notice 2.3kB   esm/models/outputsMappers.js                       
    [npmPack] npm notice 4.5kB   esm/models/parameters.js                           
    [npmPack] npm notice 7.5kB   esm/operations/privateEndpoints.js                 
    [npmPack] npm notice 2.2kB   esm/models/privateEndpointsMappers.js              
    [npmPack] npm notice 1.0kB   rollup.config.js                                   
    [npmPack] npm notice 2.1kB   esm/streamAnalyticsManagementClient.js             
    [npmPack] npm notice 2.6kB   esm/streamAnalyticsManagementClientContext.js      
    [npmPack] npm notice 15.1kB  esm/operations/streamingJobs.js                    
    [npmPack] npm notice 2.3kB   esm/models/streamingJobsMappers.js                 
    [npmPack] npm notice 1.8kB   esm/operations/subscriptions.js                    
    [npmPack] npm notice 2.2kB   esm/models/subscriptionsMappers.js                 
    [npmPack] npm notice 5.4kB   esm/operations/transformations.js                  
    [npmPack] npm notice 2.2kB   esm/models/transformationsMappers.js               
    [npmPack] npm notice 1.7kB   package.json                                       
    [npmPack] npm notice 457B    tsconfig.json                                      
    [npmPack] npm notice 519.5kB dist/arm-streamanalytics.js.map                    
    [npmPack] npm notice 70.5kB  dist/arm-streamanalytics.min.js.map                
    [npmPack] npm notice 4.1kB   esm/operations/clusters.d.ts.map                   
    [npmPack] npm notice 7.1kB   esm/operations/clusters.js.map                     
    [npmPack] npm notice 1.1kB   esm/models/clustersMappers.d.ts.map                
    [npmPack] npm notice 1.1kB   esm/models/clustersMappers.js.map                  
    [npmPack] npm notice 4.2kB   esm/operations/functions.d.ts.map                  
    [npmPack] npm notice 6.4kB   esm/operations/functions.js.map                    
    [npmPack] npm notice 1.2kB   esm/models/functionsMappers.d.ts.map               
    [npmPack] npm notice 1.2kB   esm/models/functionsMappers.js.map                 
    [npmPack] npm notice 38.4kB  esm/models/index.d.ts.map                          
    [npmPack] npm notice 313B    esm/operations/index.d.ts.map                      
    [npmPack] npm notice 126B    esm/models/index.js.map                            
    [npmPack] npm notice 328B    esm/operations/index.js.map                        
    [npmPack] npm notice 3.7kB   esm/operations/inputs.d.ts.map                     
    [npmPack] npm notice 5.7kB   esm/operations/inputs.js.map                       
    [npmPack] npm notice 1.1kB   esm/models/inputsMappers.d.ts.map                  
    [npmPack] npm notice 1.1kB   esm/models/inputsMappers.js.map                    
    [npmPack] npm notice 5.9kB   esm/models/mappers.d.ts.map                        
    [npmPack] npm notice 59.2kB  esm/models/mappers.js.map                          
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                 
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map                   
    [npmPack] npm notice 225B    esm/models/operationsMappers.d.ts.map              
    [npmPack] npm notice 238B    esm/models/operationsMappers.js.map                
    [npmPack] npm notice 3.7kB   esm/operations/outputs.d.ts.map                    
    [npmPack] npm notice 5.7kB   esm/operations/outputs.js.map                      
    [npmPack] npm notice 1.1kB   esm/models/outputsMappers.d.ts.map                 
    [npmPack] npm notice 1.1kB   esm/models/outputsMappers.js.map                   
    [npmPack] npm notice 1.0kB   esm/models/parameters.d.ts.map                     
    [npmPack] npm notice 3.4kB   esm/models/parameters.js.map                       
    [npmPack] npm notice 2.7kB   esm/operations/privateEndpoints.d.ts.map           
    [npmPack] npm notice 4.0kB   esm/operations/privateEndpoints.js.map             
    [npmPack] npm notice 1.1kB   esm/models/privateEndpointsMappers.d.ts.map        
    [npmPack] npm notice 1.1kB   esm/models/privateEndpointsMappers.js.map          
    [npmPack] npm notice 928B    esm/streamAnalyticsManagementClient.d.ts.map       
    [npmPack] npm notice 1.2kB   esm/streamAnalyticsManagementClient.js.map         
    [npmPack] npm notice 497B    esm/streamAnalyticsManagementClientContext.d.ts.map
    [npmPack] npm notice 1.4kB   esm/streamAnalyticsManagementClientContext.js.map  
    [npmPack] npm notice 4.0kB   esm/operations/streamingJobs.d.ts.map              
    [npmPack] npm notice 7.7kB   esm/operations/streamingJobs.js.map                
    [npmPack] npm notice 1.1kB   esm/models/streamingJobsMappers.d.ts.map           
    [npmPack] npm notice 1.1kB   esm/models/streamingJobsMappers.js.map             
    [npmPack] npm notice 738B    esm/operations/subscriptions.d.ts.map              
    [npmPack] npm notice 1.0kB   esm/operations/subscriptions.js.map                
    [npmPack] npm notice 1.1kB   esm/models/subscriptionsMappers.d.ts.map           
    [npmPack] npm notice 1.1kB   esm/models/subscriptionsMappers.js.map             
    [npmPack] npm notice 2.1kB   esm/operations/transformations.d.ts.map            
    [npmPack] npm notice 3.0kB   esm/operations/transformations.js.map              
    [npmPack] npm notice 1.1kB   esm/models/transformationsMappers.d.ts.map         
    [npmPack] npm notice 1.1kB   esm/models/transformationsMappers.js.map           
    [npmPack] npm notice 3.6kB   README.md                                          
    [npmPack] npm notice 11.6kB  esm/operations/clusters.d.ts                       
    [npmPack] npm notice 21.7kB  src/operations/clusters.ts                         
    [npmPack] npm notice 1.9kB   esm/models/clustersMappers.d.ts                    
    [npmPack] npm notice 2.3kB   src/models/clustersMappers.ts                      
    [npmPack] npm notice 13.7kB  esm/operations/functions.d.ts                      
    [npmPack] npm notice 24.0kB  src/operations/functions.ts                        
    [npmPack] npm notice 2.2kB   esm/models/functionsMappers.d.ts                   

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 2, 2020

azure-sdk-for-net - Release

failed [Logs] [Expand Details]
  • Generate from 90b28d0 with merge commit ec2cba2. SDK Automation 13.0.17.20200909.5
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • Microsoft.Azure.Management.StreamAnalytics [View full logs]  [Release SDK Changes]
      Failed to create the package Microsoft.Azure.Management.StreamAnalytics.
      Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=streamanalytics /v:n /p:SkipTests=true , {} 
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 11 Sep 2020 09:19:57 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:517A:154FCF:395159:5F5B413D","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 2, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 2, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 2, 2020

    azure-resource-manager-schemas - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 90b28d0 with merge commit ec2cba2. Schema Automation 13.0.17.20200909.5
      Failed to find any diff after autorest so no changed packages was found.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    3 similar comments
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 3, 2020
    @sunsw1994 sunsw1994 force-pushed the dev-streamanalytics-Microsoft.StreamAnalytics-2017-04-01-preview branch from cc08d08 to 2fb7c1d Compare September 4, 2020 05:27
    @atpham256
    Copy link
    Contributor

    I don't see examples for the new properties/feature you added. You should add them not only for documentation but to also validate the swagger based on example JSONs.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    1. update readme
    2. modify cluster type:string to object
    3. update difinition of AzureSqlReferenceInputDataSource
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @sunsw1994
    Copy link
    Contributor Author

    sunsw1994 commented Sep 10, 2020

    @weidongxu-microsoft could you help us to re-review the latest readme files for each language? We have tow new api versions, but these contains different features and no intersection.

    Which is the better or standard way for Java/Go/Ruby:

    1. Put 2020-03-01-preview and 2017-04-01-preview into a composite package. Using 2020-03-01-preview(latest version) as package suffix.
    2. Separate packages for 2020-03-01-preview and 2017-04-01-preview.

    Thank you very much.

    @atpham256
    Copy link
    Contributor

    I don't see examples for the new properties/feature you added. You should add them not only for documentation but to also validate the swagger based on example JSONs.

    Ping on this comment. It is important to have examples not only for documentation but also to validate the swagger. This will make it more likely that the SDK will work as expected.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @sunsw1994 sunsw1994 force-pushed the dev-streamanalytics-Microsoft.StreamAnalytics-2017-04-01-preview branch from 34b3789 to 58c3e81 Compare September 11, 2020 08:27
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @sunsw1994
    Copy link
    Contributor Author

    I don't see examples for the new properties/feature you added. You should add them not only for documentation but to also validate the swagger based on example JSONs.

    Ping on this comment. It is important to have examples not only for documentation but also to validate the swagger. This will make it more likely that the SDK will work as expected.

    Have updated part of example json files at commit

    @weidongxu-microsoft weidongxu-microsoft merged commit ec2cba2 into Azure:master Sep 11, 2020
    "tokenUserDisplayName": "Bob Smith",
    "groupId": "ac40305e-3e8d-43ac-8161-c33799f43e95",
    "groupName": "MyPowerBIGroup",
    "authenticationMode": "ConnectionString"
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    You should make sure examples have reasonable values. ConnectionString doesn't make sense for a PowerBI output

    nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020
    …2020-03-01-preview version for dedicated cluster (Azure#10673)
    
    * Adds base for updating Microsoft.StreamAnalytics from version stable/2016-03-01 to version 2017-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * 1.add missing features for 2017-04-01-preview based on 2016-03-01 2.fix semantic errors
    
    * add 2020-03-01-preview version for asa cluster and private endpoint
    
    * address comments 1.resourceGroupName use one unique value in example 2.suppress R3023 validation error 3.add some descriptions
    
    * address comments:
    1. update readme
    2. modify cluster type:string to object
    3. update difinition of AzureSqlReferenceInputDataSource
    
    * update example json files
    
    * add readme for python
    
    * update readme for go
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    6 participants