Dev StreamAnalytics 2017-04-01-preview version for streaming job and 2020-03-01-preview version for dedicated cluster#10673
Conversation
…2016-03-01 to version 2017-04-01-preview
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ix semantic errors
...cation/streamanalytics/resource-manager/Microsoft.StreamAnalytics/common/v1/definitions.json
Outdated
Show resolved
Hide resolved
...lytics/resource-manager/Microsoft.StreamAnalytics/preview/2017-04-01-preview/operations.json
Outdated
Show resolved
Hide resolved
...manalytics/resource-manager/Microsoft.StreamAnalytics/preview/2017-04-01-preview/inputs.json
Outdated
Show resolved
Hide resolved
cc08d08 to
2fb7c1d
Compare
...manalytics/resource-manager/Microsoft.StreamAnalytics/preview/2017-04-01-preview/inputs.json
Outdated
Show resolved
Hide resolved
...ics/resource-manager/Microsoft.StreamAnalytics/preview/2017-04-01-preview/streamingjobs.json
Show resolved
Hide resolved
...ics/resource-manager/Microsoft.StreamAnalytics/preview/2017-04-01-preview/streamingjobs.json
Show resolved
Hide resolved
...manalytics/resource-manager/Microsoft.StreamAnalytics/preview/2017-04-01-preview/inputs.json
Show resolved
Hide resolved
|
I don't see examples for the new properties/feature you added. You should add them not only for documentation but to also validate the swagger based on example JSONs. |
...nalytics/resource-manager/Microsoft.StreamAnalytics/preview/2020-03-01-preview/clusters.json
Outdated
Show resolved
Hide resolved
…ics-2017-04-01-preview
|
Azure Pipelines successfully started running 1 pipeline(s). |
1. update readme 2. modify cluster type:string to object 3. update difinition of AzureSqlReferenceInputDataSource
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@weidongxu-microsoft could you help us to re-review the latest readme files for each language? We have tow new api versions, Which is the better or standard way for Java/Go/Ruby:
Thank you very much. |
Ping on this comment. It is important to have examples not only for documentation but also to validate the swagger. This will make it more likely that the SDK will work as expected. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
34b3789 to
58c3e81
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Have updated part of example json files at commit |
| "tokenUserDisplayName": "Bob Smith", | ||
| "groupId": "ac40305e-3e8d-43ac-8161-c33799f43e95", | ||
| "groupName": "MyPowerBIGroup", | ||
| "authenticationMode": "ConnectionString" |
There was a problem hiding this comment.
You should make sure examples have reasonable values. ConnectionString doesn't make sense for a PowerBI output
…2020-03-01-preview version for dedicated cluster (Azure#10673) * Adds base for updating Microsoft.StreamAnalytics from version stable/2016-03-01 to version 2017-04-01-preview * Updates readme * Updates API version in new specs and examples * 1.add missing features for 2017-04-01-preview based on 2016-03-01 2.fix semantic errors * add 2020-03-01-preview version for asa cluster and private endpoint * address comments 1.resourceGroupName use one unique value in example 2.suppress R3023 validation error 3.add some descriptions * address comments: 1. update readme 2. modify cluster type:string to object 3. update difinition of AzureSqlReferenceInputDataSource * update example json files * add readme for python * update readme for go
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.