Skip to content

Fix concept for 11117 #11359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexanderSher wants to merge 1 commit into from
Closed

Fix concept for 11117 #11359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions ...recognizer/Azure.AI.FormRecognizer/src/Generated/Models/FormRecognizerClientExtensions.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions sdk/formrecognizer/Azure.AI.FormRecognizer/src/Generated/Models/OperationExtensions.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 9 additions & 8 deletions ...nizer/Azure.AI.FormRecognizer/tests/FormRecognizerClient/FormRecognizerClientLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,24 +131,25 @@ public async Task StartRecognizeContentPopulatesFormPage(bool useStream)
public async Task StartRecognizeReceiptsPopulatesExtractedReceipt(bool useStream)
{
var client = CreateInstrumentedClient();
Operation<IReadOnlyList<RecognizedReceipt>> operation;
IReadOnlyList<RecognizedReceipt> receipts;

if (useStream)
{
using var stream = new FileStream(TestEnvironment.ReceiptPath, FileMode.Open);
operation = await client.StartRecognizeReceiptsAsync(stream, ContentType.Jpeg);
var operation = await client.StartRecognizeReceiptsAsync(stream, ContentType.Jpeg);

await operation.WaitForCompletionAsync();

Assert.IsTrue(operation.HasValue);
receipts = operation.Value;
}
else
{
var uri = new Uri(TestEnvironment.ReceiptUri);
operation = await client.StartRecognizeReceiptsFromUriAsync(uri, default);
receipts = (await client.RecognizeReceiptsFromUriAsync(uri, default)).Value;
Copy link
Member

@annelo-msft annelo-msft Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not wild about the need to put parentheses around the expression and have .Value at the end.

Is there another approach? Krzysztof was ok with this approach...

Copy link
Contributor Author

@AlexanderSher AlexanderSher Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implicit conversion to interfaces isn't allowed. Since RecognizeReceiptsOperation uses interface as its value type:

RecognizeReceiptsOperation : Operation<IReadOnlyList<RecognizedReceipt>>

we have to either return IReadOnlyList<RecognizedReceipt> from extension method instead of Response<IReadOnlyList<RecognizedReceipt>> or change value type to ReadOnlyCollection or some other concrete type.

Copy link
Member

@maririos maririos Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When writing TA samples, Krzysztof raised this concern too, and after looking at alternatives, we went with .Value

}

await operation.WaitForCompletionAsync();

Assert.IsTrue(operation.HasValue);

var receipt = operation.Value.Single().AsUSReceipt();
var receipt = receipts.Single().AsUSReceipt();


// The expected values are based on the values returned by the service, and not the actual
Expand Down