Fix concept for 11117 #11359
Closed
Fix concept for 11117 #11359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
reviewed
Apr 16, 2020
| { | ||
| var uri = new Uri(TestEnvironment.ReceiptUri); | ||
| operation = await client.StartRecognizeReceiptsFromUriAsync(uri, default); | ||
| receipts = (await client.RecognizeReceiptsFromUriAsync(uri, default)).Value; |
Member
There was a problem hiding this comment.
I'm not wild about the need to put parentheses around the expression and have .Value at the end.
Is there another approach? Krzysztof was ok with this approach...
Contributor
Author
There was a problem hiding this comment.
Implicit conversion to interfaces isn't allowed. Since RecognizeReceiptsOperation uses interface as its value type:
RecognizeReceiptsOperation : Operation<IReadOnlyList<RecognizedReceipt>>
we have to either return IReadOnlyList<RecognizedReceipt> from extension method instead of Response<IReadOnlyList<RecognizedReceipt>> or change value type to ReadOnlyCollection or some other concrete type.
Member
There was a problem hiding this comment.
When writing TA samples, Krzysztof raised this concern too, and after looking at alternatives, we went with .Value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.