[KeyVault] tsconfig.json feedback by Will

sdk/keyvault/keyvault-certificates/src/core/index.ts

@@ -1,6 +1,3 @@
-/// <reference lib="es2015" />
-/// <reference lib="esnext.asynciterable"/>
-
 export { RestError } from '@azure/core-http';
 
 export * from "./clientOptions";

sdk/keyvault/keyvault-certificates/src/index.ts

@@ -7,8 +7,6 @@
 // This file makes more sense if ordered based on how meaningful are some methods in relation to others.
 /* eslint-disable @typescript-eslint/member-ordering */
 
-/// <reference lib="esnext.asynciterable" />
-
 import {
   TokenCredential,
   isTokenCredential,

sdk/keyvault/keyvault-certificates/src/shims-internal.d.ts

@@ -0,0 +1,5 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+/// <reference lib="dom" />
+/// <reference lib="esnext.asynciterable" />

sdk/keyvault/keyvault-certificates/tsconfig.json

@@ -3,7 +3,7 @@
   "compilerOptions": {
     "declarationDir": "./types",
     "outDir": "./dist-esm",
-    "lib": ["dom"],
+    "lib": [],
     "resolveJsonModule": true
   },
   "exclude": ["node_modules", "../keyvault-common/node_modules", "./samples/**/*.ts"],

sdk/keyvault/keyvault-keys/src/core/index.ts

@@ -1,6 +1,3 @@
-/// <reference lib="es2015" />
-/// <reference lib="esnext.asynciterable"/>
-
 export { RestError } from "@azure/core-http";
 
 export * from "./keyVaultBase";

sdk/keyvault/keyvault-keys/src/index.ts

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 /* eslint @typescript-eslint/member-ordering: 0 */
-/// <reference lib="esnext.asynciterable" />
 
 import {
   PipelineOptions,

sdk/keyvault/keyvault-keys/src/shims-internal.d.ts

@@ -0,0 +1,5 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+/// <reference lib="dom" />
+/// <reference lib="esnext.asynciterable" />

sdk/keyvault/keyvault-keys/tsconfig.json

@@ -3,7 +3,7 @@
   "compilerOptions": {
     "declarationDir": "./types",
     "outDir": "./dist-esm",
-    "lib": ["dom"],
+    "lib": [],
     "resolveJsonModule": true
   },
   "exclude": ["node_modules", "../keyvault-common/node_modules", "./samples/**/*.ts"],

sdk/keyvault/keyvault-secrets/dom-shim.d.ts

@@ -0,0 +1,7 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+// d.ts shims provide types for things we use internally but are not part
+// of this package's surface area.
+
+interface URL {}

sdk/keyvault/keyvault-secrets/src/dom.d.ts

@@ -0,0 +1,4 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+/// <reference lib="dom" />

sdk/keyvault/keyvault-secrets/src/index.ts

@@ -1,7 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 /* eslint @typescript-eslint/member-ordering: 0 */
-/// <reference lib="esnext.asynciterable" />
+
+/// <reference path="../dom-shim.d.ts" />
 
 import {
   TokenCredential,

sdk/keyvault/keyvault-secrets/tsconfig.json

@@ -3,7 +3,7 @@
   "compilerOptions": {
     "declarationDir": "./types",
     "outDir": "./dist-esm",
-    "lib": ["dom"],
+    "lib": ["dom", "esnext.asynciterable"],
     "resolveJsonModule": true
   },
   "exclude": ["node_modules", "../keyvault-common/node_modules", "./samples/**/*.ts"],