[KeyVault] tsconfig.json feedback by Will#9616
Closed
sadasant wants to merge 2 commits intoAzure:masterfrom
Closed
[KeyVault] tsconfig.json feedback by Will#9616sadasant wants to merge 2 commits intoAzure:masterfrom
sadasant wants to merge 2 commits intoAzure:masterfrom
Conversation
Contributor
|
This is waiting on a resolution to #9639 |
Contributor
|
See also microsoft/rushstack#1955 which will be helpful here if it's merged. |
Contributor
Author
|
@willmtemple I'm closing this since I believe we should step back and treat this as an issue where we haven't reached an agreement. So, closing on favor of: #10726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #8866 I merged a change suggested by Jeff, in which I moved this tsconfig.json configuration into the
index.tsfiles.Will suggests doing otherwise, so here's the PR.
From #8866 (comment)
Will will be adding some other changes to this PR, to potentially remove the
domfrom the list of injected libraries.