[KeyVault] Test utilities in a separate folder, through symbolic links and scripts#7612
Closed
sadasant wants to merge 4 commits intoAzure:masterfrom
Closed
[KeyVault] Test utilities in a separate folder, through symbolic links and scripts#7612sadasant wants to merge 4 commits intoAzure:masterfrom
sadasant wants to merge 4 commits intoAzure:masterfrom
Conversation
sadasant
added
Client
sadasant
requested review from
HarshaNalluru,
bterlson,
chradek,
daviwil,
jeremymeng,
richardpark-msft,
sophiajt and
willmtemple
This was referenced Mar 2, 2020
sadasant
changed the title
xirzec
reviewed
Mar 2, 2020
| "lint:fix": "eslint package.json tsconfig.json src test samples --ext .ts --fix --fix-type [problem,suggestion]", | ||
| "lint": "eslint package.json tsconfig.json src test samples --ext .ts -f html -o keyvault-keys-lintReport.html || exit 0", | ||
| "lint:terminal": "eslint package.json tsconfig.json src test samples --ext .ts", | ||
| "prepack": "bash ../prepack.sh", |
Member
There was a problem hiding this comment.
I mean, this won't work in command prompt on windows, yeah?
Contributor
Author
There was a problem hiding this comment.
Nope! This is only a draft. If we end up picking this approach, I can write something on another language (let's say, JavaScript 😋 )
Contributor
Author
|
Closing this on favor of: #8866 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a set of PRs made to explore together what are the possibilities of having, and managing, common code dependencies.
In this specific PR, we'll be exploring how it would be to move the common code out of KeyVault-Keys into a separate folder, bundled together through symbolic links and scripts.
Things to consider:
To do:
Your review is appreciated.