Skip to content

[KeyVault] Test utilities in a separate, private package#7611

Closed
sadasant wants to merge 10 commits intoAzure:masterfrom
sadasant:keyvault/test-utils
Closed

[KeyVault] Test utilities in a separate, private package#7611
sadasant wants to merge 10 commits intoAzure:masterfrom
sadasant:keyvault/test-utils

Conversation

@sadasant
Copy link
Copy Markdown
Contributor

@sadasant sadasant commented Mar 2, 2020

This PR is part of a set of PRs made to explore together what are the possibilities of having, and managing, common code dependencies.

In this specific PR, we'll be exploring how it would be to move the common code out of KeyVault-Keys into a separate, private, unpublished package.

Things to consider:

  • I haven't dug through the setting files to make sure they're as clean as they can possibly be.
  • I haven't moved out the same common test code from KeyVault-Secrets and KeyVault-Certificates to avoid having to have so many changes in one single PR.
  • CI might not pass right away, but I'm confident I can get it to work once we pick an approach.

To do:

  • Come up with a list of pros and cons.
  • Fix CI.

Your review is appreciated.

Please also check the other PRs:

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Mar 6, 2020

Closing on favor of #7612

@sadasant sadasant closed this Mar 6, 2020
@sadasant sadasant deleted the keyvault/test-utils branch March 6, 2020 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant