Skip to content

Regenerate Track 2 KeyVault libraries with new separated 7.1 specs #7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daviwil merged 7 commits into from
Mar 6, 2020
Merged

Regenerate Track 2 KeyVault libraries with new separated 7.1 specs #7299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
14f5cb3
Regenerate Track 2 KeyVault libraries with new separated 7.1 specs
daviwil Feb 7, 2020
d6b2d6e
Small tweaks to get all KeyVault library code to build
daviwil Feb 8, 2020
a299df4
Add missing AutoRest configuration files for KeyVault libraries
daviwil Feb 10, 2020
9e30fe7
Add missing character in keyvault-certificates swagger/README.md
daviwil Feb 10, 2020
88ec1a1
Update @azure/keyvault-keys based on final 7.1-preview changes
daviwil Mar 6, 2020
02054c5
Update @azure/keyvault-secrets based on final 7.1-preview changes
daviwil Mar 6, 2020
d505f3b
Update @azure/keyvault-certificates based on final 7.1-preview changes
daviwil Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/keyvault/keyvault-certificates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"lint:terminal": "eslint package.json \"src/**/*.ts\" samples --ext .ts",
"pack": "npm pack 2>&1",
"prebuild": "npm run clean",
"regenerate": "npx autorest swagger/README.md --typescript",
Copy link
Copy Markdown
Contributor

@sadasant sadasant Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah!! Is this all that is needed to regenerate this?

Copy link
Copy Markdown
Contributor Author

@daviwil daviwil Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, yes! I would certainly appreciate if you could clone the branch and give it a shot just to make sure.

Copy link
Copy Markdown
Contributor

@sadasant sadasant Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying it now!

Copy link
Copy Markdown
Contributor

@sadasant sadasant Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says No input files provided. Am I missing something?

Copy link
Copy Markdown
Contributor Author

@daviwil daviwil Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to commit the swagger/README.md files, fixed now :/

Copy link
Copy Markdown
Contributor

@sadasant sadasant Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! It works well!

"test:browser": "npm run clean && npm run build:test && npm run unit-test:browser",
"test:node": "npm run clean && npm run build:test && npm run unit-test:node",
"test": "npm run clean && npm run build:test && npm run unit-test",
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-certificates/review/keyvault-certificates.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export interface CertificateIssuer extends IssuerProperties {
export type CertificateKeyCurveName = "P-256" | "P-384" | "P-521" | "P-256K";

// @public
export type CertificateKeyType = "EC" | "EC-HSM" | "RSA" | "RSA-HSM";
export type CertificateKeyType = "EC" | "EC-HSM" | "RSA" | "RSA-HSM" | "oct";

// @public
export interface CertificateOperation {
Expand Down Expand Up @@ -241,7 +241,7 @@ export interface DeletedCertificate extends KeyVaultCertificateWithPolicy {
export type DeleteIssuerOptions = coreHttp.OperationOptions;

// @public
export type DeletionRecoveryLevel = "Purgeable" | "Recoverable+Purgeable" | "Recoverable" | "Recoverable+ProtectedSubscription";
export type DeletionRecoveryLevel = "Purgeable" | "Recoverable+Purgeable" | "Recoverable" | "Recoverable+ProtectedSubscription" | "CustomizedRecoverable+Purgeable" | "CustomizedRecoverable" | "CustomizedRecoverable+ProtectedSubscription";

// @public
export interface ErrorModel {
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-certificates/src/certificatesModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import { DeletionRecoveryLevel, KeyUsageType } from "./core/models";

/**
* Defines values for CertificateKeyType.
* Possible values include: 'EC', 'EC-HSM', 'RSA', 'RSA-HSM'
* Possible values include: 'EC', 'EC-HSM', 'RSA', 'RSA-HSM', 'oct'
* @readonly
* @enum {string}
*/
export type CertificateKeyType = "EC" | "EC-HSM" | "RSA" | "RSA-HSM";
export type CertificateKeyType = "EC" | "EC-HSM" | "RSA" | "RSA-HSM" | "oct";

/**
* Defines values for CertificateKeyCurveName.
Expand Down
Loading