Regenerate Track 2 KeyVault libraries with new separated 7.1 specs#7299
Regenerate Track 2 KeyVault libraries with new separated 7.1 specs#7299daviwil merged 7 commits intoAzure:masterfrom
Conversation
|
If I'm parsing the errors right in your comment, these are expected until the convenience layer is updated, since "oct-hsm" and "import" enum values were added. Was that all? |
heaths
left a comment
There was a problem hiding this comment.
I reviewed the smaller diffs in full, and sampled the larger commits - all deletions as expected. Looks good.
|
Adding @jonathandturner to spot-check the type coercions I added in commit 7319251 😄 |
There was a problem hiding this comment.
woah!! Is this all that is needed to regenerate this?
There was a problem hiding this comment.
In theory, yes! I would certainly appreciate if you could clone the branch and give it a shot just to make sure.
There was a problem hiding this comment.
It says No input files provided. Am I missing something?
There was a problem hiding this comment.
Forgot to commit the swagger/README.md files, fixed now :/
There was a problem hiding this comment.
thank you! It works well!
There was a problem hiding this comment.
The diff of this file is messy. I'm guessing we're now sorting the methods differently? I want to understand. Is this expected?
There was a problem hiding this comment.
It's expected because we're removing a large number of functions from this file which are no longer part of the spec used for @azure/keyvault-certificates The order of functions is the same, I think Git just can't figure out the proper way to diff them since the overall file structure has a lot of overlap.
There was a problem hiding this comment.
Got it! Thank you! This PR works well!
sadasant
left a comment
There was a problem hiding this comment.
Looks good! And runs good as well, locally.
5c70302 to
88ec1a1
Compare
|
I've regenerated everything here in response to the final spec changes in #7299. If tests go green after the latest CI run, I'll merge it. Thanks all! |
This change regenerates the Track 2 KeyVault data plane libraries with the new 7.1 specs that have been separated so that individual services have their own Swagger files. I've also added AutoRest configuration files and npm scripts so that it's easy for anyone to regenerate these in the future.
It appears that there have been some slight changes to the
keys.jsonspec that makes the generated code incompatible with the convenience layer:Marking this as DRAFT until the requisite spec files have been merged into the
azure-rest-api-specsrepo (PR Azure/azure-rest-api-specs#8301).