[MQ Goals] New pipeline files for event-hubs by sadasant · Pull Request #6563 · Azure/azure-sdk-for-js

sadasant · 2019-12-13T23:20:45Z

This definitely works for all of the released packages in the eventhubs folder! It took me some time to figure out everything we're doing in these tests, but I made it nonetheless! Please review 🌞

I removed the EVENTHUB_NAMEs because these resources will be created before each environment specific test run, so there will always be a fresh event hub.

Fixes #6651

sadasant · 2019-12-16T17:24:50Z

@danieljurek Hi! This template is giving me this error:

{
    "error": {
        "code": "BadRequest",
        "message": "<?xml version=\"1.0\" encoding=\"utf-8\"?><entry xmlns=\"http://www.w3.org/2005/Atom\"><id>uuid:XYZ;id=1192408</id><title type=\"text\"></title><updated>2019-12-16T17:21:35Z</updated><content type=\"application/xml\"><Error xmlns=\"\"><Message>No HTTP resource was found that matches the request URI 'https://sbgm.windows.net/subscriptions/XYZ/resourcegroups/danrodri/providers/Microsoft.EventHub/namespaces/eh10009/listKeys?api-version=2017-04-01'.</Message></Error></content></entry>"
    }
}

The error is related to the EVENTHUB_CONNECTION_STRING output. 🤔

ramya-rao-a · 2019-12-16T19:43:18Z

The event hub tests assume that event hubs with certain names already exist in the namespace.
I believe we have 9 for Node tests with OS and Node versions in the name
And we have 1 for browser test.

From what I understand, the arm template will create a new Event Hub namespace for every test run.
Does this mean that the tests will have to be updated to create the event hub required or can the arm template take care of that as well?

ramya-rao-a · 2019-12-16T19:43:31Z

cc @richardpark-msft

richardpark-msft · 2019-12-16T20:33:27Z

Looks like you can use the same ARM template to create things all the way down to the individual eventhub level:

https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/101-eventhubs-create-namespace-and-eventhub/azuredeploy.json

sadasant · 2019-12-16T20:52:20Z

Oh this explains a lot. Yes, I can do this at this level. I'll put an update up.

ramya-rao-a

The test-resources.json file is in the eventhub folder which contains 3 different projects

event hubs
eventhubs-checkpointstore-blob
event processor host

Do we intend this file to apply to all 3 projects?

sadasant · 2019-12-17T21:44:50Z

@ramya-rao-a that's the idea. Thanks for pointing that out, I haven't tested that this works in the others. We can split them up to make them individual, but so far we've been able to have one for all of the clients of a given service. This does add some delay to my progress, since I wasn't aware there were three packages for this service.

ramya-rao-a · 2019-12-17T22:42:28Z

The first two in the list can definitely share the same arm template
The third can use the same arm template, but will need a slightly different value for the iot hub connection string env variable.
We can solve the problem by using a different env variable for iot hub for the third case

sadasant · 2019-12-17T22:49:57Z

@ramya-rao-a sounds good! please let me know what's this extra environment variable and I'll add it today.

ramya-rao-a · 2019-12-18T02:19:17Z

I have made the relevant changes in #6614
Once that is merged, and this PR gets updated to use the latest from master, refer to #6436 to understand how to get the 2 different connection strings for IotHub.

sadasant · 2019-12-18T19:46:01Z

@ramya-rao-a the changes in this PR should be good to merge as soon as your PR is merged and Daniel Jurek work is also in 🌞

sadasant · 2019-12-19T19:38:59Z

/azp run js - event-hubs - tests

azure-pipelines · 2019-12-19T19:39:04Z

No pipelines are associated with this pull request.

sadasant · 2019-12-19T21:58:22Z

/azp run js - eventhubs-client - tests

danieljurek · 2019-12-19T21:58:25Z

/azp run js - eventhubs-client - tests

azure-pipelines · 2019-12-19T21:58:33Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-19T21:58:35Z

Azure Pipelines successfully started running 1 pipeline(s).

ramya-rao-a · 2019-12-19T22:48:27Z

The tests are failing with Connection string malformed: each part of the connection string must have an = assignment.

Looks like the connection string is not being set in the right env variable

sadasant · 2019-12-19T23:18:00Z

@ramya-rao-a I'll be able to check this probably later if I don't get more feedback on the keyvault side. Otherwise tomorrow.

sadasant · 2019-12-19T23:33:29Z

/azp run js - eventhubs-client - tests

azure-pipelines · 2019-12-19T23:33:40Z

Azure Pipelines successfully started running 1 pipeline(s).

sadasant · 2019-12-20T06:01:39Z

/azp run js - eventhubs-client - tests

azure-pipelines · 2019-12-20T06:01:50Z

Azure Pipelines successfully started running 1 pipeline(s).

sadasant · 2019-12-20T06:04:03Z

/azp run js - eventhubs-client - tests

azure-pipelines · 2019-12-20T06:04:13Z

Azure Pipelines successfully started running 1 pipeline(s).

sadasant · 2019-12-20T06:09:45Z

/azp run js - eventhubs-client - tests

azure-pipelines · 2019-12-20T06:09:56Z

Azure Pipelines successfully started running 1 pipeline(s).

sadasant · 2019-12-20T06:14:46Z

/azp run js - eventhubs-client - tests

azure-pipelines · 2019-12-20T06:14:56Z

Azure Pipelines successfully started running 1 pipeline(s).

sadasant · 2019-12-20T06:18:16Z

/azp run js - eventhubs-client - tests

azure-pipelines · 2019-12-20T06:18:27Z

Azure Pipelines successfully started running 1 pipeline(s).

sadasant · 2019-12-20T12:53:28Z

/azp run js - eventhubs-client - tests

azure-pipelines · 2019-12-20T12:53:39Z

Azure Pipelines successfully started running 1 pipeline(s).

sadasant · 2019-12-20T13:42:18Z

ha! Daniel Jurek helped me figure out what was wrong! yayyy

sadasant · 2019-12-20T13:52:53Z

/azp run js - eventhubs-processor - tests

azure-pipelines · 2019-12-20T13:53:04Z

Azure Pipelines successfully started running 1 pipeline(s).

sadasant · 2019-12-20T14:58:09Z

@ramya-rao-a this is ready to be merged! 🎉

sadasant · 2020-01-06T18:12:25Z

/azp run js - eventhubs-client - tests

azure-pipelines · 2020-01-06T18:12:36Z

Azure Pipelines successfully started running 1 pipeline(s).

sadasant · 2020-01-06T18:42:20Z

One test is failing on Windows 8. I'll study it later.

ramya-rao-a · 2020-01-06T19:12:46Z

@sadasant The failing test is not related to the set up, it is a flaky test.
Please go ahead and merge this PR.

sadasant requested review from danieljurek and ramya-rao-a December 13, 2019 23:20

sadasant self-assigned this Dec 13, 2019

sadasant marked this pull request as ready for review December 17, 2019 14:41

sadasant requested review from chradek and richardpark-msft as code owners December 17, 2019 14:41

ramya-rao-a reviewed Dec 17, 2019

View reviewed changes

sadasant changed the title ~~[MQ Goals] New pipeline files for event-hubs~~ WIP [MQ Goals] New pipeline files for event-hubs Dec 17, 2019

ramya-rao-a mentioned this pull request Dec 18, 2019

[Event Hubs] Use different env name for EH compatible connection string in IotHub #6614

Merged

sadasant changed the title ~~WIP [MQ Goals] New pipeline files for event-hubs~~ [MQ Goals] New pipeline files for event-hubs Dec 18, 2019

I have two more ideas, heres one

52d0d85

my last last idea

0a67aea

maybe this is a thing?

b4782b6

I need to know whatss this before I leave

0645127

maybe this isnt helping

0b2f160

nothing works, going back

9536019

ramya-rao-a approved these changes Dec 20, 2019

View reviewed changes

sadasant mentioned this pull request Dec 20, 2019

[WIP][MQ Goals] ARM template for Storage #6459

Closed

sadasant merged commit 79a6e98 into Azure:master Jan 6, 2020

sadasant deleted the feature/MQ-event-hubs branch January 6, 2020 19:13

Conversation

sadasant commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sadasant commented Dec 16, 2019

Uh oh!

ramya-rao-a commented Dec 16, 2019

Uh oh!

ramya-rao-a commented Dec 16, 2019

Uh oh!

richardpark-msft commented Dec 16, 2019

Uh oh!

sadasant commented Dec 16, 2019

Uh oh!

ramya-rao-a left a comment

Choose a reason for hiding this comment

Uh oh!

sadasant commented Dec 17, 2019

Uh oh!

ramya-rao-a commented Dec 17, 2019

Uh oh!

sadasant commented Dec 17, 2019

Uh oh!

ramya-rao-a commented Dec 18, 2019

Uh oh!

sadasant commented Dec 18, 2019

Uh oh!

sadasant commented Dec 19, 2019

Uh oh!

azure-pipelines bot commented Dec 19, 2019

Uh oh!

sadasant commented Dec 19, 2019

Uh oh!

danieljurek commented Dec 19, 2019

Uh oh!

azure-pipelines bot commented Dec 19, 2019

Uh oh!

azure-pipelines bot commented Dec 19, 2019

Uh oh!

ramya-rao-a commented Dec 19, 2019

Uh oh!

sadasant commented Dec 19, 2019

Uh oh!

sadasant commented Dec 19, 2019

Uh oh!

azure-pipelines bot commented Dec 19, 2019

Uh oh!

sadasant commented Dec 20, 2019

Uh oh!

azure-pipelines bot commented Dec 20, 2019

Uh oh!

sadasant commented Dec 20, 2019

Uh oh!

azure-pipelines bot commented Dec 20, 2019

Uh oh!

sadasant commented Dec 20, 2019

Uh oh!

azure-pipelines bot commented Dec 20, 2019

Uh oh!

sadasant commented Dec 20, 2019

Uh oh!

azure-pipelines bot commented Dec 20, 2019

Uh oh!

sadasant commented Dec 20, 2019

Uh oh!

azure-pipelines bot commented Dec 20, 2019

Uh oh!

sadasant commented Dec 20, 2019

Uh oh!

azure-pipelines bot commented Dec 20, 2019

Uh oh!

sadasant commented Dec 20, 2019

Uh oh!

sadasant commented Dec 20, 2019

Uh oh!

azure-pipelines bot commented Dec 20, 2019

Uh oh!

sadasant commented Dec 20, 2019

Uh oh!

sadasant commented Jan 6, 2020

sadasant commented Dec 13, 2019 •

edited

Loading