Skip to content

[WIP][MQ Goals] ARM template for Storage#6459

Closed
sadasant wants to merge 24 commits intoAzure:masterfrom
sadasant:feature/storage-MQ-blob
Closed

[WIP][MQ Goals] ARM template for Storage#6459
sadasant wants to merge 24 commits intoAzure:masterfrom
sadasant:feature/storage-MQ-blob

Conversation

@sadasant
Copy link
Copy Markdown
Contributor

@sadasant sadasant commented Dec 6, 2019 •
edited
Loading

TODO:

  • Make sure that everything is fine once Heath's PR becomes part of this repo too!

Heath's PR: Azure/azure-sdk-for-net#9029

Fixes #6652

@sadasant sadasant requested a review from danieljurek December 6, 2019 23:26
@sadasant sadasant self-assigned this Dec 6, 2019
danieljurek
danieljurek reviewed Dec 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple late changes that I've updated in our docs. Also the file should be named test-resources.json ... the extra s at the end of test was brought forward from the arcane ways I set up when doing this for KV.

We're also heading toward pulling all of the storage live test pipelines into a single service pipeline. In that case we'd need to collapse blobs, queues, files, datalake, etc. into a single test-resources.json file.

@sadasant sadasant changed the title [MQ Goals] ARM template for Storage Blob [MQ Goals] ARM template for Storage Dec 9, 2019
@danieljurek
Copy link
Copy Markdown
Member

danieljurek commented Dec 9, 2019

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 9, 2019

Azure Pipelines failed to run 1 pipeline(s).

@danieljurek
Copy link
Copy Markdown
Member

danieljurek commented Dec 9, 2019

/azp run js - storage-file-share - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 9, 2019

Azure Pipelines failed to run 1 pipeline(s).

@danieljurek
Copy link
Copy Markdown
Member

danieljurek commented Dec 9, 2019

/azp run js - storage-queue - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 9, 2019

Azure Pipelines failed to run 1 pipeline(s).

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 9, 2019

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 9, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 9, 2019

/azp run js - storage-file-share - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 9, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 9, 2019

/azp run js - storage-file-datalake - tests

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 9, 2019

/azp run js - storage-queue - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 9, 2019

No pipelines are associated with this pull request.

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 9, 2019

Azure Pipelines successfully started running 1 pipeline(s).

danieljurek
danieljurek reviewed Dec 9, 2019
View reviewed changes
@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 9, 2019

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 9, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 9, 2019

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 9, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 10, 2019

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 10, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant sadasant force-pushed the feature/storage-MQ-blob branch from 3a67628 to 4d7a685 Compare December 10, 2019 20:27
@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 11, 2019

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 11, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant sadasant marked this pull request as ready for review December 19, 2019 18:57
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 20, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 20, 2019

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 20, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 20, 2019

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 20, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 20, 2019

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 20, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 20, 2019

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Dec 20, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Dec 20, 2019

I'm getting this error on CI:

New-AzResourceGroupDeployment : 5:53:59 PM - Error: Code=InvalidTemplateDeployment; Message=The template deployment 't53790dc83a004991' is not valid according to the validation procedure. The tracking id is 'a463d03c-f36a-4331-a539-7558753caed3'. See inner errors for details.
At /home/vsts/work/1/s/eng/New-TestResources.ps1:205 char:19
+ ... eployment = New-AzResourceGroupDeployment -Name $BaseName -ResourceGr ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [New-AzResourceGroupDeployment], Exception
+ FullyQualifiedErrorId : Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.NewAzureResourceGroupDeploymentCmdlet

You can see it here: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=217019&view=logs&j=84bf07a8-cb34-5cff-7973-062fa4a8d0b8&t=ac5916d0-e2ed-5793-a495-8e359fbb80df&l=26

I'm not sure what to do with it. A similar ARM template worked for event-hubs: #6563

@HarshaNalluru
Copy link
Copy Markdown
Contributor

HarshaNalluru commented Jan 3, 2020

@sadasant the link says Build not found, can you trigger it again?

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Jan 6, 2020

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 6, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant
Copy link
Copy Markdown
Contributor Author

sadasant commented Jan 15, 2020

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 15, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@sadasant sadasant requested a review from ljian3377 as a code owner January 15, 2020 23:43
@HarshaNalluru
Copy link
Copy Markdown
Contributor

HarshaNalluru commented Jan 15, 2020

/azp run js - storage-blob - tests

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 15, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@HarshaNalluru HarshaNalluru changed the title [MQ Goals] ARM template for Storage [WIP][MQ Goals] ARM template for Storage Jan 16, 2020
@HarshaNalluru HarshaNalluru mentioned this pull request Jan 16, 2020
Merged
@HarshaNalluru
Copy link
Copy Markdown
Contributor

HarshaNalluru commented Jan 24, 2020

Closing this in favour of #6982

@HarshaNalluru HarshaNalluru self-assigned this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieljurek danieljurek danieljurek left review comments

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

@jiacfan jiacfan Awaiting requested review from jiacfan

@vinjiang vinjiang Awaiting requested review from vinjiang

@XiaoningLiu XiaoningLiu Awaiting requested review from XiaoningLiu

@ljian3377 ljian3377 Awaiting requested review from ljian3377

Assignees

@sadasant sadasant

@HarshaNalluru HarshaNalluru

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MQ] Update Storage tests.yml and test-resources.json

3 participants

@sadasant @danieljurek @HarshaNalluru