[KeyVault] Remove dependency on @azure/core-arm#5494
Merged
daviwil merged 4 commits intoAzure:masterfrom Oct 10, 2019
Merged
Conversation
daviwil
changed the title
daviwil
commented
Oct 10, 2019
Contributor
Author
daviwil
left a comment
daviwil
left a comment
There was a problem hiding this comment.
We also need to remove core-arm from keyvault-certificates package.json
| import * as coreArm from "@azure/core-arm"; | ||
|
|
||
| const packageName = "@azure/keyvault-certificates"; | ||
| const packageName = "@azure/keyvault-keys"; |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| const packageName = "@azure/keyvault-keys"; | |
| const packageName = "@azure/keyvault-certificates"; |
| } | ||
|
|
||
| this.client = new KeyVaultClient(credential, this.pipeline); | ||
| this.client = new KeyVaultClient(credential, "7.0", this.pipeline); |
Contributor
Author
There was a problem hiding this comment.
I wonder if we should make this a constant in this file with a comment saying that we are using it temporarily until an issue with autorest.typescript is fixed?
| this.pipeline = pipelineOrOptions; | ||
| } | ||
| this.client = new KeyVaultClient(credential, this.pipeline); | ||
| this.client = new KeyVaultClient(credential, "7.0", this.pipeline); |
| this.pipeline.requestPolicyFactories; | ||
|
|
||
| this.client = new KeyVaultClient(credential, this.pipeline); | ||
| this.client = new KeyVaultClient(credential, "7.0", this.pipeline); |
| } | ||
|
|
||
| this.client = new KeyVaultClient(credential, this.pipeline); | ||
| this.client = new KeyVaultClient(credential, "7.0", this.pipeline); |
daviwil
changed the title
sophiajt
approved these changes
Oct 10, 2019
Contributor
Author
|
Merging it! |
This was referenced Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
@azure/keyvault-*libraries' dependency on@azure/core-arm, pair developed with @jonathandturner.