[KeyVault] [TypeScript] azure-arm is not needed#6996
Merged
Conversation
Following up on David Wilson's issue: Azure/azure-sdk-for-js#4386 This is pending though: > Once we do decide to remove it and send a PR to the azure-rest-api-specs repo, we'll have to use autorest.typescript to regenerate the keyvault modules again. What would be the action item at this point? Help & feedback appreciated.
In Testing, Please Ignore[Logs] (Generated from 4b916f6, Iteration 3)
|
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Contributor
|
Can one of the admins verify this patch? |
daviwil
approved these changes
Aug 22, 2019
Member
Contributor
|
|
Contributor
|
We removed the need for this parameter in the KeyVault data plane libraries in PR Azure/azure-sdk-for-js#5494 so it's safe to merge this now! |
yungezz
approved these changes
Oct 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on David Wilson's issue: Azure/azure-sdk-for-js#4386
This is pending though:
What would be the action item at this point?
Help & feedback appreciated.
Fixes Azure/azure-sdk-for-js#4386.