[Record and Playback] Skip functionality in common recorder#4898
Merged
HarshaNalluru merged 2 commits intoAzure:masterfrom Aug 27, 2019
Merged
[Record and Playback] Skip functionality in common recorder#4898HarshaNalluru merged 2 commits intoAzure:masterfrom
HarshaNalluru merged 2 commits intoAzure:masterfrom
Conversation
sophiajt
reviewed
Aug 26, 2019
sadasant
approved these changes
Aug 26, 2019
Contributor
sadasant
left a comment
There was a problem hiding this comment.
Follow the feedback and land this! 🌞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip list to skip a test -
Managing the list of test names would mean that we should frequently update them whenever a test name changes or a new test is added.
The plan is to avoid the skip list becoming stale in the following way.
This PR attempts to provide a .skip() method with the recorder from
@azure/test-utils-recorderthat can be called from theitblock to skip a test.Let us take a moment to understand what happens with this change.
recorder.skip("browser");orrecorder.skip("node");in theitblock based on the environment we want the test to be skippeditblock.[ A small tradeoff for getting rid of skip list and still add the convenience of invoking the recorder in beforeeach ]
Reference - #4336