Record and playback - POC for skip functionality in common recorder#4336
Closed
HarshaNalluru wants to merge 2 commits intoAzure:feature/storagefrom
Closed
Record and playback - POC for skip functionality in common recorder#4336HarshaNalluru wants to merge 2 commits intoAzure:feature/storagefrom
HarshaNalluru wants to merge 2 commits intoAzure:feature/storagefrom
Conversation
Contributor
Author
|
Update Guildelines accordingly. |
XiaoningLiu
reviewed
Jul 18, 2019
| public skip(): boolean { | ||
| return skip.includes(this.filepath); | ||
| } | ||
| // public skip(): boolean { |
Member
There was a problem hiding this comment.
Do we still need commentted code here?
Contributor
Author
There was a problem hiding this comment.
No, this will be deleted.
This current PR is just to show how the skip list can be avoided and hear some feedback for it.
Instead of doing the updates in recorder.ts files, I'm planning to update the new common recorder #4281.
Member
|
|
Contributor
Author
|
Thanks, @XiaoningLiu, I like the |
This was referenced Aug 23, 2019
Contributor
Author
|
#4898 is merged, Closing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managing the list of test names would mean that we should frequently update them whenever a test name changes or a new test is added.
The plan is to avoid the skip list becoming stale in the following way.
Providing a .skip() method with the recorder so that it can be called from the
itblock to skip a test.Let us take a moment to understand what happens with this change.
recorder.skip("browser");orrecorder.skip("node");in theitblock based on the environment we want the test to be skippeditblock.[ A small tradeoff for getting rid of skip list and still add the convenience of invoking the recorder in beforeeach ]
[WIP] Will rebase and merge this in the common recorder module which is in PR - #4281
/cc - @ramya-rao-a @XiaoningLiu @kinelski @sadasant