Merged
Conversation
This should fix the build.
sadasant
requested review from
ShivangiReja,
chradek and
ramya-rao-a
as code owners
sadasant
commented
Aug 8, 2019
mikeharder
requested changes
Aug 8, 2019
sophiajt
approved these changes
Aug 8, 2019
mikeharder
approved these changes
Aug 8, 2019
Member
mikeharder
left a comment
mikeharder
left a comment
There was a problem hiding this comment.
Approved pending test results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the build.
For the record:
This PR changed the tests, but I did not update the recordings: https://github.com/Azure/azure-sdk-for-js/pull/4688/files