Skip to content

[KeyVault] Fix flaky tests around the getDeleted* tests #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadasant merged 3 commits into from
Aug 8, 2019
Merged

[KeyVault] Fix flaky tests around the getDeleted* tests #4688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec6f3cf
[KeyVault] Fix flaky tests around the getDeleted* tests
sadasant Aug 6, 2019
c83dab7
Update list.test.ts
sadasant Aug 6, 2019
ea5436a
Update list.test.ts
sadasant Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions sdk/keyvault/keyvault-keys/tests/list.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,10 @@ describe("Keys client - list keys in various ways", () => {
await client.deleteKey(name);
}

// Waiting until the key is deleted
await retry(async () => client.getDeletedKey(keyNames[0]));
// Waiting until the keys are deleted
for (const name of keyNames) {
await retry(async () => client.getDeletedKey(name));
}

let found = 0;
for await (const key of client.listDeletedKeys()) {
Expand All @@ -165,8 +167,10 @@ describe("Keys client - list keys in various ways", () => {
await client.deleteKey(name);
}

// Waiting until the key is deleted
await retry(async () => client.getDeletedKey(keyNames[0]));
// Waiting until the keys are deleted
for (const name of keyNames) {
await retry(async () => client.getDeletedKey(name));
}

let found = 0;
for await (const page of client.listDeletedKeys().byPage()) {
Expand Down
12 changes: 8 additions & 4 deletions sdk/keyvault/keyvault-secrets/tests/list.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,10 @@ describe("Secret client - list secrets in various ways", () => {
await client.deleteSecret(name);
}

// Waiting until the key is deleted
await retry(async () => client.getDeletedSecret(secretNames[0]));
// Waiting until the secrets are deleted
for (const name of secretNames) {
await retry(async () => client.getDeletedSecret(name));
}

let found = 0;
for await (const secret of client.listDeletedSecrets()) {
Expand Down Expand Up @@ -164,8 +166,10 @@ describe("Secret client - list secrets in various ways", () => {
await client.deleteSecret(name);
}

// Waiting until the key is deleted
await retry(async () => client.getDeletedSecret(secretNames[0]));
// Waiting until the secrets are deleted
for (const name of secretNames) {
await retry(async () => client.getDeletedSecret(name));
}

let found = 0;
for await (const page of client.listDeletedSecrets().byPage()) {
Expand Down