[Storage] Verify SharedKeyCredential type only in NodeJS runtime#4604
Merged
HarshaNalluru merged 1 commit intoAzure:feature/storagefrom Aug 1, 2019
Merged
Conversation
HarshaNalluru
added
Client
XiaoningLiu
approved these changes
Aug 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup PR for #4466
While adding the SAS connection string support to the existing connection string methods, observed that the browser tests failed because of undefined object
SharedKeyCredential.This PR fixes the issue by not letting the code path hit the
SharedKeyCredentialin the browser and is required for #4372