[Storage] Better integration of @azure/identity#4466
Merged
HarshaNalluru merged 3 commits intoAzure:feature/storagefrom Jul 31, 2019
Merged
[Storage] Better integration of @azure/identity#4466HarshaNalluru merged 3 commits intoAzure:feature/storagefrom
HarshaNalluru merged 3 commits intoAzure:feature/storagefrom
Conversation
…| AnonymousCredential | TokenCredential
HarshaNalluru
added
Client
daviwil
approved these changes
Jul 26, 2019
Contributor
daviwil
left a comment
daviwil
left a comment
There was a problem hiding this comment.
Thanks Harsha, this looks good to me! Would also like to know what @XiaoningLiu thinks.
ramya-rao-a
approved these changes
Jul 30, 2019
This was referenced Jul 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the union type of credential to
credential: SharedKeyCredential | AnonymousCredential | TokenCredentialfor storage-blob and storage-queue.Issue - #3944