Skip to content

[KeyVault] Adds abortSignal to all the *Options we have in keys and secrets #4383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadasant merged 1 commit into from
Jul 23, 2019
Merged

[KeyVault] Adds abortSignal to all the *Options we have in keys and secrets #4383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/keyvault/keyvault-keys/review/keyvault-keys.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,20 @@ export type DeletionRecoveryLevel = "Purgeable" | "Recoverable+Purgeable" | "Rec

// @public
export interface GetKeyOptions {
abortSignal?: AbortSignalLike;
requestOptions?: msRest.RequestOptionsBase;
version?: string;
}

// @public
export interface GetKeysOptions {
abortSignal?: AbortSignalLike;
requestOptions?: msRest.RequestOptionsBase;
}

// @public
export interface ImportKeyOptions {
abortSignal?: AbortSignalLike;
enabled?: boolean;
expires?: Date;
hsm?: boolean;
Expand Down Expand Up @@ -177,6 +180,7 @@ export interface ProxyOptions {

// @public
export interface RequestOptions {
abortSignal?: AbortSignalLike;
requestOptions?: msRest.RequestOptionsBase;
}

Expand All @@ -195,6 +199,7 @@ export interface TelemetryOptions {

// @public
export interface UpdateKeyOptions {
abortSignal?: AbortSignalLike;
enabled?: boolean;
expires?: Date;
keyOps?: JsonWebKeyOperation[];
Expand Down
20 changes: 20 additions & 0 deletions sdk/keyvault/keyvault-keys/src/keysModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,10 @@ export interface ImportKeyOptions {
* @member {msRest.RequestOptionsBase} [requestOptions] Options for this request
*/
requestOptions?: msRest.RequestOptionsBase;
/**
* @member {AbortSignalLike} [abortSignal] Abort signal
*/
abortSignal?: AbortSignalLike;
}

/**
Expand Down Expand Up @@ -235,6 +239,10 @@ export interface UpdateKeyOptions {
* @member {msRest.RequestOptionsBase} [requestOptions] Options for this request
*/
requestOptions?: msRest.RequestOptionsBase;
/**
* @member {AbortSignalLike} [abortSignal] Abort signal
*/
abortSignal?: AbortSignalLike;
}

/**
Expand All @@ -252,6 +260,10 @@ export interface GetKeyOptions {
* @member {msRest.RequestOptionsBase} [requestOptions] Options for this request
*/
requestOptions?: msRest.RequestOptionsBase;
/**
* @member {AbortSignalLike} [abortSignal] Abort signal
*/
abortSignal?: AbortSignalLike;
}

/**
Expand All @@ -264,6 +276,10 @@ export interface ListKeysOptions {
* @member {msRest.RequestOptionsBase} [requestOptions] Options for this request
*/
requestOptions?: msRest.RequestOptionsBase;
/**
* @member {AbortSignalLike} [abortSignal] Abort signal
*/
abortSignal?: AbortSignalLike;
}

/**
Expand All @@ -275,4 +291,8 @@ export interface RequestOptions {
* @member {msRest.RequestOptionsBase} [requestOptions] Options for this request
*/
requestOptions?: msRest.RequestOptionsBase;
/**
* @member {AbortSignalLike} [abortSignal] Abort signal
*/
abortSignal?: AbortSignalLike;
}
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-secrets/review/keyvault-secrets.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,14 @@ export type DeletionRecoveryLevel = "Purgeable" | "Recoverable+Purgeable" | "Rec

// @public
export interface GetSecretOptions {
abortSignal?: AbortSignalLike;
requestOptions?: msRest.RequestOptionsBase;
version?: string;
}

// @public
export interface GetSecretsOptions {
abortSignal?: AbortSignalLike;
requestOptions?: msRest.RequestOptionsBase;
}

Expand Down Expand Up @@ -137,6 +139,7 @@ export interface TelemetryOptions {

// @public
export interface UpdateSecretOptions {
abortSignal?: AbortSignalLike;
contentType?: string;
enabled?: boolean;
expires?: Date;
Expand Down
12 changes: 12 additions & 0 deletions sdk/keyvault/keyvault-secrets/src/secretsModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ export interface UpdateSecretOptions {
* @member {msRest.RequestOptionsBase} [requestOptions] Options for this request
*/
requestOptions?: msRest.RequestOptionsBase;
/**
* @member {AbortSignalLike} [abortSignal] Abort signal
*/
abortSignal?: AbortSignalLike;
}

/**
Expand All @@ -200,6 +204,10 @@ export interface GetSecretOptions {
* @member {msRest.RequestOptionsBase} [requestOptions] Options for this request
*/
requestOptions?: msRest.RequestOptionsBase;
/**
* @member {AbortSignalLike} [abortSignal] Abort signal
*/
abortSignal?: AbortSignalLike;
}

/**
Expand All @@ -212,4 +220,8 @@ export interface ListSecretsOptions {
* @member {msRest.RequestOptionsBase} [requestOptions] Options for this request
*/
requestOptions?: msRest.RequestOptionsBase;
/**
* @member {AbortSignalLike} [abortSignal] Abort signal
*/
abortSignal?: AbortSignalLike;
}