[KeyVault] Adds abortSignal to all the *Options we have in keys and secrets#4383
Merged
sadasant merged 1 commit intoAzure:masterfrom Jul 23, 2019
Merged
[KeyVault] Adds abortSignal to all the *Options we have in keys and secrets#4383sadasant merged 1 commit intoAzure:masterfrom
sadasant merged 1 commit intoAzure:masterfrom
Conversation
…ecrets With these changes, our current API fully supports cancelling a request before we get a response. The idea is that this feature is already supported by the core dependencies we use, and by passing this property through, we'll get the benefits right away without having to do other changes. keyvault-keys and keyvault-secrets currently have a unit test that proves that this works for one of the functions that shares this underlying APIs. This PR adds the support to the other similar methods. We could also add other tests demonstrating this behavior for these other functions. Fixes Azure#4357
sadasant
added
Client
Contributor
|
cc @bterlson - I can't remember where we landed with cancellation. Would you mind looking at this to see if it matches with your expectations? |
bterlson
approved these changes
Jul 22, 2019
Member
bterlson
left a comment
bterlson
left a comment
There was a problem hiding this comment.
LGTM (abortSignal option typed as AbortSignalLike interface)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, our current API fully supports cancelling a request
before we get a response. The idea is that this feature is already
supported by the core dependencies we use, and by passing this property
through, we'll get the benefits right away without having to do other
changes.
keyvault-keys and keyvault-secrets currently have a unit test that
proves that this works for one of the functions that shares this
underlying APIs. This PR adds the support to the other similar methods.
We could also add other tests demonstrating this behavior for these
other functions.
Fixes #4357