[Event Hubs][@azure/event-hubs_2.1.0] Added event handler error and protocolError on the connection object.#4318
Merged
ShivangiReja merged 3 commits intoAzure:event-hubs_2.1.1from Jul 15, 2019
Conversation
… `protocolError` on the connection object.
ramya-rao-a
reviewed
Jul 15, 2019
ramya-rao-a
reviewed
Jul 15, 2019
| }; | ||
|
|
||
| const protocolError: OnAmqpEvent = async (context: EventContext) => { | ||
| const connectionError = context.connection && context.connection.error ? context.connection.error : undefined; |
Contributor
There was a problem hiding this comment.
undefined is the natural state of things. So this can be simplified to const connectionError = context.connection && context.connection.error;
On second thoughts, I would skip the need for the constants connectionError and contextError and use the context object directly
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
ramya-rao-a
approved these changes
Jul 15, 2019
Contributor
|
@chradek fyi |
Contributor
|
This is in lieu of updating an older version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
errorandprotocolErroron the connection object inconnectionContext.tsthat will just log the error and take care of the unhandled exception