[EPH] Update event-hub version to 2.1.1 and make it compatible with EPH#4333
Merged
ShivangiReja merged 11 commits intoAzure:masterfrom Jul 16, 2019
Merged
[EPH] Update event-hub version to 2.1.1 and make it compatible with EPH#4333ShivangiReja merged 11 commits intoAzure:masterfrom
ShivangiReja merged 11 commits intoAzure:masterfrom
Conversation
ramya-rao-a
reviewed
Jul 16, 2019
ramya-rao-a
reviewed
Jul 16, 2019
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
ramya-rao-a
reviewed
Jul 16, 2019
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
…fixes in changelog
ramya-rao-a
reviewed
Jul 16, 2019
ramya-rao-a
reviewed
Jul 16, 2019
| - Use the latest version of the dependency on [@azure/event-hubs](https://www.npmjs.com/package/@azure/event-hubs/v/2.1.1) that has fixes for the following bugs | ||
| - Added event handlers for `error` and `protocolError` events on the connection object to avoid the case of unhandled exceptions. This is related to the [bug 4136](https://github.com/Azure/azure-sdk-for-js/issues/4136) | ||
| - A network connection lost error is now treated as retryable error. A new error with name `ConnectionLostError` | ||
| is introduced for this scenario which you can see if you enable the [logs](https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/eventhub/event-hubs#enable-logs). |
Contributor
There was a problem hiding this comment.
Can EPH users use the same kind of logging mechanism? Should we point them to the section in EPH instead of EH?
Member
Author
There was a problem hiding this comment.
I also thought about it but above we mentioned that event hubs has the following bug fixes that's why I added the link for event hubs logging mechanism.
Event hubs logging mechanism is different than EPH:
Event hubs : export DEBUG=azure*
EPH: export DEBUG=azure:eph*
Member
Author
There was a problem hiding this comment.
I'll update the link to point them to the EPH debug section.
Co-Authored-By: Ramya Rao <ramya.rao.a@outlook.com>
ShivangiReja
added
the
Client
ramya-rao-a
approved these changes
Jul 16, 2019
ramya-rao-a
approved these changes
Jul 16, 2019
mikeharder
added a commit
to mikeharder/azure-sdk-for-js
that referenced
this pull request
Jul 26, 2019
- Continuation of Azure#4333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@azure/event-hubs: "^2.1.1"in EPH package.jsonms-rest-azure->@azure/ms-rest-nodeauthto make EPH compatible with updated event hubs versionMore more context: #4136, #4318