Skip to content

Switch Rollup minifier plugin to rollup-plugin-terser #4203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daviwil merged 8 commits into from
Jul 12, 2019
Merged

Switch Rollup minifier plugin to rollup-plugin-terser #4203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f47532e
Use rollup-plugin-terser in @azure/abort-controller
daviwil Jul 8, 2019
57a79ab
Use rollup-plugin-terser in @azure/core-amqp
daviwil Jul 8, 2019
161d14d
Use rollup-plugin-terser in @azure/core-auth
daviwil Jul 8, 2019
d1c7dec
Use rollup-plugin-terser in @azure/event-hubs
daviwil Jul 8, 2019
6a70772
Use rollup-plugin-terser in @azure/storage-blob
daviwil Jul 8, 2019
310b364
Use rollup-plugin-terser in @azure/storage-file
daviwil Jul 8, 2019
5a1c5b0
Use rollup-plugin-terser in @azure/storage-queue
daviwil Jul 8, 2019
335caa5
Use rollup-plugin-terser in the SDK library template
daviwil Jul 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/core/abort-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"rollup-plugin-node-resolve": "^5.0.2",
"rollup-plugin-replace": "^2.1.0",
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-uglify": "^6.0.0",
"rollup-plugin-terser": "^5.1.1",
"typescript": "^3.2.2"
}
}
6 changes: 3 additions & 3 deletions sdk/core/abort-controller/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import nodeResolve from "rollup-plugin-node-resolve";
import multiEntry from "rollup-plugin-multi-entry";
import cjs from "rollup-plugin-commonjs";
import replace from "rollup-plugin-replace";
import { uglify } from "rollup-plugin-uglify";
import { terser } from "rollup-plugin-terser";
import sourcemaps from "rollup-plugin-sourcemaps";

const pkg = require("./package.json");
Expand Down Expand Up @@ -57,7 +57,7 @@ export function nodeConfig(test = false) {
// applies to test code, which causes all tests to be removed by tree-shaking.
baseConfig.treeshake = false;
} else if (production) {
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down Expand Up @@ -118,7 +118,7 @@ export function browserConfig(test = false) {
// applies to test code, which causes all tests to be removed by tree-shaking.
baseConfig.treeshake = false;
} else if (production) {
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-amqp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"rollup-plugin-replace": "^2.1.0",
"rollup-plugin-shim": "^1.0.0",
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-uglify": "^6.0.0",
"rollup-plugin-terser": "^5.1.1",
"sinon": "^7.1.0",
"ts-node": "^7.0.1",
"typescript": "^3.2.2",
Expand Down
6 changes: 3 additions & 3 deletions sdk/core/core-amqp/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import nodeResolve from "rollup-plugin-node-resolve";
import multiEntry from "rollup-plugin-multi-entry";
import cjs from "rollup-plugin-commonjs";
import replace from "rollup-plugin-replace";
import { uglify } from "rollup-plugin-uglify";
import { terser } from "rollup-plugin-terser";
import sourcemaps from "rollup-plugin-sourcemaps";
import inject from "rollup-plugin-inject";
import shim from "rollup-plugin-shim";
Expand Down Expand Up @@ -78,7 +78,7 @@ export function nodeConfig(test = false) {
// applies to test code, which causes all tests to be removed by tree-shaking.
baseConfig.treeshake = false;
} else if (production) {
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down Expand Up @@ -162,7 +162,7 @@ export function browserConfig(test = false) {
// applies to test code, which causes all tests to be removed by tree-shaking.
baseConfig.treeshake = false;
} else if (production) {
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"rollup-plugin-node-resolve": "^5.0.2",
"rollup-plugin-replace": "^2.1.0",
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-uglify": "^6.0.0",
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^2.0.0",
"typescript": "^3.2.2",
"util": "^0.11.1"
Expand Down
16 changes: 13 additions & 3 deletions sdk/core/core-auth/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import nodeResolve from "rollup-plugin-node-resolve";
import multiEntry from "rollup-plugin-multi-entry";
import cjs from "rollup-plugin-commonjs";
import replace from "rollup-plugin-replace";
import { uglify } from "rollup-plugin-uglify";
import { terser } from "rollup-plugin-terser";
import sourcemaps from "rollup-plugin-sourcemaps";
import viz from "rollup-plugin-visualizer";

Expand Down Expand Up @@ -43,8 +43,13 @@ export function nodeConfig(test = false) {

// mark assert as external
baseConfig.external.push("assert");

// Disable tree-shaking of test code. In rollup-plugin-node-resolve@5.0.0, rollup started respecting
Copy link
Contributor Author

@daviwil daviwil Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that core-auth didn't have the tree-shaking test fix that was introduced in #3997 so I added it here so that tests will run correctly.

// the "sideEffects" field in package.json. Since our package.json sets "sideEffects=false", this also
// applies to test code, which causes all tests to be removed by tree-shaking.
baseConfig.treeshake = false;
} else if (production) {
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down Expand Up @@ -86,9 +91,14 @@ export function browserConfig(test = false, production = false) {
baseConfig.input = "dist-esm/test/**/*.spec.js";
baseConfig.plugins.unshift(multiEntry({ exports: false }));
baseConfig.output.file = "test-browser/index.js";

// Disable tree-shaking of test code. In rollup-plugin-node-resolve@5.0.0, rollup started respecting
// the "sideEffects" field in package.json. Since our package.json sets "sideEffects=false", this also
// applies to test code, which causes all tests to be removed by tree-shaking.
baseConfig.treeshake = false;
} else if (production) {
baseConfig.output.file = "browser/core-auth.min.js";
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/event-hubs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
"rollup-plugin-replace": "^2.1.0",
"rollup-plugin-shim": "^1.0.0",
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-uglify": "^6.0.0",
"rollup-plugin-terser": "^5.1.1",
"ts-mocha": "^6.0.0",
"ts-node": "^7.0.1",
"typescript": "^3.2.2",
Expand Down
6 changes: 3 additions & 3 deletions sdk/eventhub/event-hubs/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import multiEntry from "rollup-plugin-multi-entry";
import cjs from "rollup-plugin-commonjs";
import json from "rollup-plugin-json";
import replace from "rollup-plugin-replace";
import { uglify } from "rollup-plugin-uglify";
import { terser } from "rollup-plugin-terser";
import sourcemaps from "rollup-plugin-sourcemaps";
import shim from "rollup-plugin-shim";
import inject from "rollup-plugin-inject";
Expand Down Expand Up @@ -79,7 +79,7 @@ export function nodeConfig(test = false) {
// applies to test code, which causes all tests to be removed by tree-shaking.
baseConfig.treeshake = false;
} else if (production) {
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down Expand Up @@ -170,7 +170,7 @@ export function browserConfig(test = false) {
// applies to test code, which causes all tests to be removed by tree-shaking.
baseConfig.treeshake = false;
} else if (production) {
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
"rollup-plugin-replace": "^2.1.0",
"rollup-plugin-shim": "^1.0.0",
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-uglify": "^6.0.0",
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^2.0.0",
"source-map-support": "^0.5.9",
"ts-node": "^7.0.1",
Expand Down
6 changes: 3 additions & 3 deletions sdk/storage/storage-blob/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import nodeResolve from "rollup-plugin-node-resolve";
import multiEntry from "rollup-plugin-multi-entry";
import cjs from "rollup-plugin-commonjs";
import replace from "rollup-plugin-replace";
import { uglify } from "rollup-plugin-uglify";
import { terser } from "rollup-plugin-terser";
import sourcemaps from "rollup-plugin-sourcemaps";
import shim from "rollup-plugin-shim";
// import visualizer from "rollup-plugin-visualizer";
Expand Down Expand Up @@ -66,7 +66,7 @@ export function nodeConfig(test = false) {
// applies to test code, which causes all tests to be removed by tree-shaking.
baseConfig.treeshake = false;
} else if (production) {
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down Expand Up @@ -135,7 +135,7 @@ export function browserConfig(test = false, production = false) {
} else if (production) {
baseConfig.output.file = "browser/azure-storage-blob.min.js";
baseConfig.plugins.push(
uglify({
terser({
output: {
preamble: banner
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-file/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
"rollup-plugin-replace": "^2.1.0",
"rollup-plugin-shim": "^1.0.0",
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-uglify": "^6.0.0",
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^2.0.0",
"source-map-support": "^0.5.9",
"ts-node": "^7.0.1",
Expand Down
6 changes: 3 additions & 3 deletions sdk/storage/storage-file/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import nodeResolve from "rollup-plugin-node-resolve";
import multiEntry from "rollup-plugin-multi-entry";
import cjs from "rollup-plugin-commonjs";
import replace from "rollup-plugin-replace";
import { uglify } from "rollup-plugin-uglify";
import { terser } from "rollup-plugin-terser";
import sourcemaps from "rollup-plugin-sourcemaps";
import shim from "rollup-plugin-shim";
// import visualizer from "rollup-plugin-visualizer";
Expand Down Expand Up @@ -66,7 +66,7 @@ export function nodeConfig(test = false) {
// applies to test code, which causes all tests to be removed by tree-shaking.
baseConfig.treeshake = false;
} else if (production) {
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down Expand Up @@ -144,7 +144,7 @@ export function browserConfig(test = false, production = false) {
} else if (production) {
baseConfig.output.file = "browser/azure-storage-file.min.js";
baseConfig.plugins.push(
uglify({
terser({
output: {
preamble: banner
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-queue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
"rollup-plugin-replace": "^2.1.0",
"rollup-plugin-shim": "^1.0.0",
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-uglify": "^6.0.0",
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^2.0.0",
"source-map-support": "^0.5.9",
"ts-node": "^7.0.1",
Expand Down
6 changes: 3 additions & 3 deletions sdk/storage/storage-queue/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import nodeResolve from "rollup-plugin-node-resolve";
import multiEntry from "rollup-plugin-multi-entry";
import cjs from "rollup-plugin-commonjs";
import replace from "rollup-plugin-replace";
import { uglify } from "rollup-plugin-uglify";
import { terser } from "rollup-plugin-terser";
import sourcemaps from "rollup-plugin-sourcemaps";
import shim from "rollup-plugin-shim";
// import visualizer from "rollup-plugin-visualizer";
Expand Down Expand Up @@ -66,7 +66,7 @@ export function nodeConfig(test = false) {
// applies to test code, which causes all tests to be removed by tree-shaking.
baseConfig.treeshake = false;
} else if (production) {
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down Expand Up @@ -133,7 +133,7 @@ export function browserConfig(test = false, production = false) {
} else if (production) {
baseConfig.output.file = "browser/azure-storage-queue.min.js";
baseConfig.plugins.push(
uglify({
terser({
output: {
preamble: banner
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/template/template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"rollup-plugin-node-resolve": "^5.0.2",
"rollup-plugin-replace": "^2.1.0",
"rollup-plugin-sourcemaps": "^0.4.2",
"rollup-plugin-uglify": "^6.0.0",
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-visualizer": "^2.0.0",
"typescript": "^3.2.2",
"util": "^0.11.1"
Expand Down
6 changes: 3 additions & 3 deletions sdk/template/template/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import nodeResolve from "rollup-plugin-node-resolve";
import multiEntry from "rollup-plugin-multi-entry";
import cjs from "rollup-plugin-commonjs";
import replace from "rollup-plugin-replace";
import { uglify } from "rollup-plugin-uglify";
import { terser } from "rollup-plugin-terser";
import sourcemaps from "rollup-plugin-sourcemaps";
import viz from "rollup-plugin-visualizer";

Expand Down Expand Up @@ -49,7 +49,7 @@ export function nodeConfig(test = false) {
// applies to test code, which causes all tests to be removed by tree-shaking.
baseConfig.treeshake = false;
} else if (production) {
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down Expand Up @@ -103,7 +103,7 @@ export function browserConfig(test = false, production = false) {
baseConfig.treeshake = false;
} else if (production) {
baseConfig.output.file = "browser/azure-template.min.js";
baseConfig.plugins.push(uglify());
baseConfig.plugins.push(terser());
}

return baseConfig;
Expand Down