Skip to content

Update rollup-plugin-node-resolve to 5.0.2#3997

Merged
mikeharder merged 4 commits intoAzure:masterfrom
mikeharder:rollup-plugin-node-resolve-disable-tree-shaking
Jun 25, 2019
Merged

Update rollup-plugin-node-resolve to 5.0.2#3997
mikeharder merged 4 commits intoAzure:masterfrom
mikeharder:rollup-plugin-node-resolve-disable-tree-shaking

Conversation

@mikeharder
Copy link
Member

@mikeharder mikeharder commented Jun 21, 2019

This PR updates dev dependency rollup-plugin-node-resolve from ^4.2.0 to ^5.0.2. This is required for compat with resolve@1.11.1 (rollup/rollup-plugin-node-resolve#222).

Part of this PR was generated by running the following command:

cd sdk\servicebus\service-bus
rush add -p rollup-plugin-node-resolve@5.0.2 --dev --caret --make-consistent

There are 3 meaningful changes:

  1. In all impacted package.json files, dev dependency rollup-plugin-node-resolve was updated from ^4.2.0 to ^5.0.2.
  2. Tree-shaking was disabled for test code. In rollup-plugin-node-resolve@5.0.0, rollup started respecting the "sideEffects" field in package.json. Since our package.json sets "sideEffects=false", this also applies to test code, which causes all tests to be removed by tree-shaking.
  3. pnpm-lock.yaml was updated to the latest matching versions of all floated packages.

All other changes should just be re-arranging lines in package.json, which is done automatically by Rush.

CC: @ramya-rao-a, @jonathandturner

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants