-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[AutoPR @azure-arm-edgeactions]-generated-from-SDK Generation - JS-5759847 #37048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoPR @azure-arm-edgeactions]-generated-from-SDK Generation - JS-5759847 #37048
Conversation
…eActions/tspconfig.yaml', API Version: 2025-12-01-preview, SDK Release Type: beta, and CommitSHA: '3fc43b6c80d8fce282a242b1f34fecced80ddcb5' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5759847 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
this release is blocked on #37179 |
@kazrael2119 The fix in core is merged and will be released at 2/5 and pls try again then. |
…eActions/tspconfig.yaml', API Version: 2025-12-01-preview, SDK Release Type: beta, and CommitSHA: '24902354a88f1ca5349ea3049edae370599c8e57' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5849998 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@MaryGao would you have a look at this again. Merged the pr on specs repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a newly generated Azure Resource Manager (management-plane) JavaScript/TypeScript SDK package @azure/arm-edgeactions (API version 2025-12-01-preview, beta) plus its CI wiring, samples, and API review artifacts.
Changes:
- Adds the new
sdk/edgeactions/arm-edgeactionspackage (client, models, operations, helpers, lint/vitest/api-extractor config). - Adds TypeScript/JavaScript samples (and samples-dev) plus API Extractor review files.
- Adds repo integration updates (service CI pipeline YAML, pnpm lock entry, CODEOWNERS, link-ignore).
Reviewed changes
Copilot reviewed 120 out of 121 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/edgeactions/ci.mgmt.yml | Adds the mgmt CI pipeline definition for the new edgeactions service directory. |
| sdk/edgeactions/arm-edgeactions/vitest.esm.config.ts | Adds Vitest ESM config for the package. |
| sdk/edgeactions/arm-edgeactions/vitest.config.ts | Adds default Vitest config that re-exports shared repo config. |
| sdk/edgeactions/arm-edgeactions/vitest.browser.config.ts | Adds Vitest browser config that re-exports shared repo config. |
| sdk/edgeactions/arm-edgeactions/tsp-location.yaml | Records the TypeSpec/spec repo location and commit used to generate this package. |
| sdk/edgeactions/arm-edgeactions/tsconfig.test.node.json | Adds Node test TS config with path aliases for tests. |
| sdk/edgeactions/arm-edgeactions/tsconfig.test.json | Adds TS project references for tests (node + browser configs). |
| sdk/edgeactions/arm-edgeactions/tsconfig.src.json | Adds TS config for compiling library sources. |
| sdk/edgeactions/arm-edgeactions/tsconfig.snippets.json | Adds snippet compilation config. |
| sdk/edgeactions/arm-edgeactions/tsconfig.samples.json | Adds samples compilation config. |
| sdk/edgeactions/arm-edgeactions/tsconfig.json | Adds TS project references for src/samples/tests/snippets. |
| sdk/edgeactions/arm-edgeactions/tsconfig.browser.config.json | Adds browser TS config with path aliases. |
| sdk/edgeactions/arm-edgeactions/test/snippets.spec.ts | Adds snippet-harness file for README snippet extraction. |
| sdk/edgeactions/arm-edgeactions/test/public/utils/recordedClient.ts | Adds recorder setup helper for future recorded tests. |
| sdk/edgeactions/arm-edgeactions/test/public/sampleTest.spec.ts | Adds a placeholder public test. |
| sdk/edgeactions/arm-edgeactions/src/static-helpers/urlTemplate.ts | Adds RFC6570 URL template expansion helper used by generated operations. |
| sdk/edgeactions/arm-edgeactions/src/static-helpers/pollingHelpers.ts | Adds LRO poller helper wrapping @azure/core-lro. |
| sdk/edgeactions/arm-edgeactions/src/static-helpers/pagingHelpers.ts | Adds paging helper that returns PagedAsyncIterableIterator. |
| sdk/edgeactions/arm-edgeactions/src/static-helpers/cloudSettingHelpers.ts | Adds cloud setting enum + ARM endpoint resolver. |
| sdk/edgeactions/arm-edgeactions/src/restorePollerHelpers.ts | Adds helper to restore pollers from serialized state. |
| sdk/edgeactions/arm-edgeactions/src/models/index.ts | Exposes generated model types from the package entrypoint. |
| sdk/edgeactions/arm-edgeactions/src/logger.ts | Adds package logger. |
| sdk/edgeactions/arm-edgeactions/src/index.ts | Main package exports (client, models, ops groups, paging, clouds, restorePoller). |
| sdk/edgeactions/arm-edgeactions/src/classic/index.ts | Exposes “classic” operation-group interfaces. |
| sdk/edgeactions/arm-edgeactions/src/classic/edgeActions/index.ts | Adds EdgeActions operation-group interface and implementation wrapper. |
| sdk/edgeactions/arm-edgeactions/src/classic/edgeActionVersions/index.ts | Adds EdgeActionVersions operation-group interface and implementation wrapper. |
| sdk/edgeactions/arm-edgeactions/src/classic/edgeActionExecutionFilters/index.ts | Adds EdgeActionExecutionFilters operation-group interface and implementation wrapper. |
| sdk/edgeactions/arm-edgeactions/src/cdnClient.ts | Implements the top-level CdnClient that wires operation groups. |
| sdk/edgeactions/arm-edgeactions/src/api/index.ts | Exposes createCdn and context types. |
| sdk/edgeactions/arm-edgeactions/src/api/edgeActions/options.ts | Adds operation option types for EdgeActions. |
| sdk/edgeactions/arm-edgeactions/src/api/edgeActions/operations.ts | Adds generated REST operations for EdgeActions endpoints. |
| sdk/edgeactions/arm-edgeactions/src/api/edgeActions/index.ts | Re-exports EdgeActions operations + option types. |
| sdk/edgeactions/arm-edgeactions/src/api/edgeActionVersions/options.ts | Adds operation option types for EdgeActionVersions. |
| sdk/edgeactions/arm-edgeactions/src/api/edgeActionVersions/operations.ts | Adds generated REST operations for EdgeActionVersions endpoints. |
| sdk/edgeactions/arm-edgeactions/src/api/edgeActionVersions/index.ts | Re-exports EdgeActionVersions operations + option types. |
| sdk/edgeactions/arm-edgeactions/src/api/edgeActionExecutionFilters/options.ts | Adds operation option types for EdgeActionExecutionFilters. |
| sdk/edgeactions/arm-edgeactions/src/api/edgeActionExecutionFilters/operations.ts | Adds generated REST operations for EdgeActionExecutionFilters endpoints. |
| sdk/edgeactions/arm-edgeactions/src/api/edgeActionExecutionFilters/index.ts | Re-exports EdgeActionExecutionFilters operations + option types. |
| sdk/edgeactions/arm-edgeactions/src/api/cdnContext.ts | Creates the REST client context (endpoint/scopes/api-version policy/logging). |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/tsconfig.json | Adds TS config for the published TypeScript samples package. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionsUpdateSample.ts | Adds TS sample for EdgeActions update. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionsListBySubscriptionSample.ts | Adds TS sample for listing EdgeActions by subscription. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionsListByResourceGroupSample.ts | Adds TS sample for listing EdgeActions by resource group. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionsGetSample.ts | Adds TS sample for getting an EdgeAction. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionsDeleteSample.ts | Adds TS sample for deleting an EdgeAction. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionsCreateSample.ts | Adds TS sample for creating an EdgeAction. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionVersionsUpdateSample.ts | Adds TS sample for EdgeActionVersions update. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionVersionsSwapDefaultSample.ts | Adds TS sample for swapping default version. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionVersionsListByEdgeActionSample.ts | Adds TS sample for listing versions by EdgeAction. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionVersionsGetVersionCodeSample.ts | Adds TS sample for getVersionCode LRO. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionVersionsGetSample.ts | Adds TS sample for getting an EdgeActionVersion. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionVersionsDeployVersionCodeSample.ts | Adds TS sample for deployVersionCode LRO. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionVersionsDeleteSample.ts | Adds TS sample for deleting an EdgeActionVersion. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionVersionsCreateSample.ts | Adds TS sample for creating an EdgeActionVersion. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionExecutionFiltersUpdateSample.ts | Adds TS sample for execution filter update. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionExecutionFiltersListByEdgeActionSample.ts | Adds TS sample for listing execution filters. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionExecutionFiltersGetSample.ts | Adds TS sample for getting an execution filter. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionExecutionFiltersDeleteSample.ts | Adds TS sample for deleting an execution filter. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/src/edgeActionExecutionFiltersCreateSample.ts | Adds TS sample for creating an execution filter. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/sample.env | Adds env template for TS samples. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/package.json | Adds package.json for TS samples project. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/typescript/README.md | Adds readme for TS samples. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/sample.env | Adds env template for JS samples. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/package.json | Adds package.json for JS samples project. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionsUpdateSample.js | Adds JS sample for EdgeActions update. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionsListBySubscriptionSample.js | Adds JS sample for listing EdgeActions by subscription. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionsListByResourceGroupSample.js | Adds JS sample for listing EdgeActions by resource group. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionsGetSample.js | Adds JS sample for getting an EdgeAction. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionsDeleteSample.js | Adds JS sample for deleting an EdgeAction. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionsCreateSample.js | Adds JS sample for creating an EdgeAction. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionVersionsUpdateSample.js | Adds JS sample for EdgeActionVersions update. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionVersionsSwapDefaultSample.js | Adds JS sample for swapping default version. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionVersionsListByEdgeActionSample.js | Adds JS sample for listing versions by EdgeAction. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionVersionsGetVersionCodeSample.js | Adds JS sample for getVersionCode LRO. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionVersionsGetSample.js | Adds JS sample for getting an EdgeActionVersion. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionVersionsDeployVersionCodeSample.js | Adds JS sample for deployVersionCode LRO. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionVersionsDeleteSample.js | Adds JS sample for deleting an EdgeActionVersion. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionVersionsCreateSample.js | Adds JS sample for creating an EdgeActionVersion. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionExecutionFiltersUpdateSample.js | Adds JS sample for execution filter update. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionExecutionFiltersListByEdgeActionSample.js | Adds JS sample for listing execution filters. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionExecutionFiltersGetSample.js | Adds JS sample for getting an execution filter. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionExecutionFiltersDeleteSample.js | Adds JS sample for deleting an execution filter. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/edgeActionExecutionFiltersCreateSample.js | Adds JS sample for creating an execution filter. |
| sdk/edgeactions/arm-edgeactions/samples/v1-beta/javascript/README.md | Adds readme for JS samples. |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionsUpdateSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionsListBySubscriptionSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionsListByResourceGroupSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionsGetSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionsDeleteSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionsCreateSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionVersionsUpdateSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionVersionsSwapDefaultSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionVersionsListByEdgeActionSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionVersionsGetVersionCodeSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionVersionsGetSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionVersionsDeployVersionCodeSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionVersionsDeleteSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionVersionsCreateSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionExecutionFiltersUpdateSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionExecutionFiltersListByEdgeActionSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionExecutionFiltersGetSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionExecutionFiltersDeleteSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/samples-dev/edgeActionExecutionFiltersCreateSample.ts | Adds developer samples for local runs (TS). |
| sdk/edgeactions/arm-edgeactions/sample.env | Adds env template for package-level tooling. |
| sdk/edgeactions/arm-edgeactions/review/arm-edgeactions-node.api.md | Adds API Extractor report for main entrypoint. |
| sdk/edgeactions/arm-edgeactions/review/arm-edgeactions-models-node.api.md | Adds API Extractor report for models entrypoint. |
| sdk/edgeactions/arm-edgeactions/review/arm-edgeactions-api-node.api.md | Adds API Extractor report for api entrypoint. |
| sdk/edgeactions/arm-edgeactions/review/arm-edgeactions-api-edgeActions-node.api.md | Adds API Extractor report for edgeActions entrypoint. |
| sdk/edgeactions/arm-edgeactions/review/arm-edgeactions-api-edgeActionVersions-node.api.md | Adds API Extractor report for edgeActionVersions entrypoint. |
| sdk/edgeactions/arm-edgeactions/review/arm-edgeactions-api-edgeActionExecutionFilters-node.api.md | Adds API Extractor report for edgeActionExecutionFilters entrypoint. |
| sdk/edgeactions/arm-edgeactions/package.json | Adds package manifest (exports, scripts, dependencies). |
| sdk/edgeactions/arm-edgeactions/metadata.json | Adds generation metadata including xlang mappings. |
| sdk/edgeactions/arm-edgeactions/eslint.config.mjs | Adds eslint config for the package. |
| sdk/edgeactions/arm-edgeactions/api-extractor.json | Adds API Extractor config. |
| sdk/edgeactions/arm-edgeactions/README.md | Adds package README with usage and snippets. |
| sdk/edgeactions/arm-edgeactions/LICENSE | Adds package license file. |
| sdk/edgeactions/arm-edgeactions/CHANGELOG.md | Adds initial changelog entry for beta. |
| pnpm-lock.yaml | Adds workspace lock entries for the new package. |
| eng/ignore-links.txt | Adds docs link ignore entry for the new API reference URL. |
| .github/CODEOWNERS | Adds code owners entry for the new package directory. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
sdk/edgeactions/arm-edgeactions/src/classic/edgeActionExecutionFilters/index.ts
Show resolved
Hide resolved
|
@tundwed FYI, feel free to follow this guide to add some real test cases for your service, |
I have verified this fix, it works |
# Conflicts: # pnpm-lock.yaml
working on this |
…eActions/tspconfig.yaml', API Version: 2025-12-01-preview, SDK Release Type: beta, and CommitSHA: 'c38368d5a70af78fbaaf927c194f5a6c2e83aaed' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5858694 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
- Add edgeActionsManagement.spec.ts with CRUD tests for edgeActions and edgeActionVersions - Fix null deserialization crash for sku and attachments in models.ts - Set up recordedClient.ts with recorder utilities and sanitizers - Add assets.json pointing to test recordings in azure-sdk-assets
ARM management tests are not applicable to browser environments. Exclude edgeActionsManagement.spec.js from browser test configuration.
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| import { CdnClient } from "../src/index.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why there is no error? since CdnClient should be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is because we will not update metadata files in subsequent generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have updated the client name and done the re-generation, but we will not update metadata files in subsequent generation, so the new client name can't be updated in this file or readme.md
We will create an issue to track this in code gen repo.
@jeremymeng Do we also need to have a check to check if this file has compile issue in sdk-PR's side?
Configurations: 'specification/cdn/resource-manager/Microsoft.Cdn/EdgeActions/tspconfig.yaml', API Version: 2025-12-01-preview, SDK Release Type: beta, and CommitSHA: '3fc43b6c80d8fce282a242b1f34fecced80ddcb5' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5759847 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=9e03d787-20ec-f011-8544-000d3a5b5a24 Submitted by: dannytundwe@microsoft.com
Release Plan Details
Spec pull request: Use CustomPatch for EdgeActions Service azure-rest-api-specs#39517
Spec API version: 2025-12-01-preview