[AutoPR @azure-arm-edgemarketplace]-generated-from-SDK Generation - JS-5751507#37035
[AutoPR @azure-arm-edgemarketplace]-generated-from-SDK Generation - JS-5751507#37035azure-sdk wants to merge 1 commit intoAzure:mainfrom
Conversation
…ace.Management/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '06616874d9002bb259ca541be63272c3a4edafa8' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5751507 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
aviranjan24
requested review from
a team,
JialinHuang803,
MaryGao,
jeremymeng and
qiaozha
as code owners
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new auto-generated SDK package @azure/arm-edgemarketplace for the Azure Edge Marketplace service, generated from TypeSpec definitions for API version 2025-10-01-preview.
Changes:
- Adds complete SDK package structure with client, models, operations, and helper utilities
- Includes TypeScript configuration, build scripts, and testing infrastructure
- Provides code samples in both TypeScript and JavaScript
- Adds CI/CD pipeline configuration and API review files
Reviewed changes
Copilot reviewed 90 out of 91 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/edgemarketplace/ci.mgmt.yml | CI pipeline configuration for the package |
| sdk/edgemarketplace/arm-edgemarketplace/package.json | Package manifest with dependencies and scripts |
| sdk/edgemarketplace/arm-edgemarketplace/src/edgeMarketplaceClient.ts | Main client class implementation |
| sdk/edgemarketplace/arm-edgemarketplace/src/models/models.ts | Model types and serializers/deserializers |
| sdk/edgemarketplace/arm-edgemarketplace/src/api/**/*.ts | API operation implementations |
| sdk/edgemarketplace/arm-edgemarketplace/src/static-helpers/*.ts | Helper utilities for pagination, polling, URL templates |
| sdk/edgemarketplace/arm-edgemarketplace/test/**/*.ts | Test infrastructure and placeholder tests |
| sdk/edgemarketplace/arm-edgemarketplace/samples*/** | Sample code in TypeScript and JavaScript |
| sdk/edgemarketplace/arm-edgemarketplace/review/*.api.md | API review files for tracking public surface |
| Various config files | TypeScript, build, linting, and testing configurations |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| export enum KnownVersions { | ||
| /** Version 2024-10-01 */ | ||
| V20241001 = "2024-10-01", | ||
| /** Version 2025-10-01-preview */ | ||
| V20251001Preview = "2025-10-01-preview", |
There was a problem hiding this comment.
The API version "2024-10-01" appears to be in the past, but according to the PR description, the API version should be "2025-10-01-preview". The KnownVersions enum includes "2024-10-01" which may not be the correct version for this new SDK. Please verify this is intentional or if only "2025-10-01-preview" should be included.
There was a problem hiding this comment.
The KnownVersions enum would contain existing api-versions so 2024-10-01 would be included.
| /** The region where the disk will be created. */ | ||
| edgeMarketPlaceRegion: string; | ||
| /** The region where the disk will be created. */ | ||
| egeMarketPlaceResourceId?: string; |
There was a problem hiding this comment.
The property name "egeMarketPlaceResourceId" appears to have a typo - it should likely be "edgeMarketPlaceResourceId" (with "dge" not "ge"). This inconsistency exists while the correct spelling "edgeMarketPlaceRegion" is used on line 638.
There was a problem hiding this comment.
@kazrael2119 could you find the original spec pr and comment the typo issue here?
There was a problem hiding this comment.
@aviranjan24 could you help confirm if here is a typo issue?
|
Hello, we kindly request that you hold off on reviewing this PR until we provide further updates from our business side approval. Thank you for your patience. |
7 participants
Configurations: 'specification/edgemarketplace/Microsoft.EdgeMarketPlace.Management/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '06616874d9002bb259ca541be63272c3a4edafa8' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5751507 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=cbfb86b0-12f1-f011-8407-000d3a5d2e0b Submitted by: aviranjan@microsoft.com
Release Plan Details
Spec pull request: Edge Marketplace new 2025-10-01 preview API version azure-rest-api-specs#38124
Spec API version: 2025-10-01-preview