Skip to content

Allow empty string as valid sessionId #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramya0820 merged 1 commit into from
May 30, 2019
Merged

Allow empty string as valid sessionId #3300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/servicebus/service-bus/src/receiver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ export class SessionReceiver {
});
// By this point, we should have a valid sessionId on the messageSession
// If not, the receiver cannot be used, so throw error.
if (!this._messageSession.sessionId) {
if (this._messageSession.sessionId == null) {
const error = new Error("Something went wrong. Cannot lock a session.");
log.error(`[${this._context.namespace.connectionId}] %O`, error);
throw error;
Expand Down