Allow empty string as valid sessionId#3300
Merged
Merged
Conversation
ramya-rao-a
approved these changes
May 30, 2019
Contributor
|
Do we know if the corresponding tests ever passed? |
Member
Author
Looks like not since 5/23 - https://dev.azure.com/azure-sdk/internal/_test/analytics?definitionId=91&contextType=build |
Contributor
|
Those tests were added in #2823 on May 11th. So, if these tests ran successfully since then until May 23rd, it makes me worried as to what exactly changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more context refer to #3269