[Storage] Make Aborter parameter optional - storage-file#2908
Conversation
HarshaNalluru
added
Client
jeremymeng
left a comment
jeremymeng
left a comment
There was a problem hiding this comment.
can you base you change on top of feature\storage? We will merge updates from master in separate PRs.
XiaoningLiu
left a comment
XiaoningLiu
left a comment
There was a problem hiding this comment.
Noticed new added options with I prefix, while @jeremymeng is working on remove I prefixes.
Generally looks good to me, please make sure all tests passed.
Why this PR includes changes for other SDKs?
|
Yup. Ran the tests locally, all the tests have passed. |
HarshaNalluru
force-pushed
the
OptionalAborterParam
branch
from
7e21f59 to
ff7666b
Compare
| import { appendToURLPath } from "./utils/utils.common"; | ||
|
|
||
| export interface IDirectoryCreateOptions { | ||
| abortSignal?: Aborter; |
There was a problem hiding this comment.
Need to copy and paste some documentation for abortSignal
|
/azp run azure-sdk-for-js - all-tests - storage-file |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I have some draft doc for /**
* Aborter instance to cancel request. It can be created with Aborter.none
* or Aborter.timeout(). Go to documents of {@link Aborter} for more examples
* about request cancellation.
*
* @type {Aborter}
* @memberof IUploadToBlockBlobOptions
*/
abortSignal?: Aborter;Edited: add code snippet type |
|
Looks good to me |
3 participants
Use Aborter.none as the default value.
Issue - #2628
Reference - #2296