Skip to content

Make Aborter parameter optional#2296

Merged
jeremymeng merged 2 commits into
Azure:jeremymeng/storage-ux-studyfrom
jeremymeng:optional-aborter-parameters
Apr 22, 2019
Merged

Make Aborter parameter optional#2296
jeremymeng merged 2 commits into
Azure:jeremymeng/storage-ux-studyfrom
jeremymeng:optional-aborter-parameters

Conversation

@jeremymeng
Copy link
Copy Markdown
Member

Use Aborter.none as the default value.

Use Aborter.none as the default value.
@jeremymeng jeremymeng requested a review from bterlson April 16, 2019 22:26
@jeremymeng jeremymeng added the Client This issue points to a problem in the data-plane of the library. label Apr 19, 2019
@jeremymeng jeremymeng self-assigned this Apr 19, 2019
@jeremymeng jeremymeng added the Storage Storage Service (Queues, Blobs, Files) label Apr 19, 2019
Copy link
Copy Markdown
Member

@bterlson bterlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@jeremymeng jeremymeng merged commit 49fd50c into Azure:jeremymeng/storage-ux-study Apr 22, 2019
@jeremymeng jeremymeng deleted the optional-aborter-parameters branch April 22, 2019 17:29
jeremymeng added a commit to jeremymeng/azure-sdk-for-js that referenced this pull request May 10, 2019
* Make Aborter parameter optional

Use Aborter.none as the default value.

* Pass abortSignal to stageBlock() call
jeremymeng added a commit to jeremymeng/azure-sdk-for-js that referenced this pull request May 16, 2019
* Make Aborter parameter optional

Use Aborter.none as the default value.
jeremymeng added a commit that referenced this pull request May 17, 2019
* Make Aborter parameter optional

Use Aborter.none as the default value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants