[core-rest-pipeline] Address issue with proxy port setting being ignored#28974
Merged
Conversation
xirzec
requested review from
bterlson,
deyaaeldeen,
jeremymeng,
mpodwysocki and
timovv
as code owners
mpodwysocki
approved these changes
Mar 19, 2024
timovv
reviewed
Mar 19, 2024
Member
timovv
left a comment
timovv
left a comment
There was a problem hiding this comment.
Can we get this in ts-http-runtime as well?
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
When can we expect the patched version of |
Member
|
This change will be in 1.15.1 which I plan to release later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/core-rest-pipelineIssues associated with this PR
#28951
Describe the problem that is addressed by this PR
When PR #28563 upgraded
http-proxy-agentit didn't properly pass alongportas this is now encoded in the proxy URL instead of the agent options.This PR trims down the unnecessary parsing we are doing to turn the proxy URL into
ProxySettings, preferring to pass the URL as-is tohttp-proxy-agentand avoid losing information. In cases where we receiveProxySettingswe will convert it into a URL correctly.For unknown historical reasons,
getDefaultProxySettingswas exposed as public surface, but since we no longer need this internally, I have marked it as deprecated so we may remove it in a later major version.Are there test cases added in this PR? (If not, why?)
Existing tests were updated to validate the proxy URL being set correctly on the agent itself.