[core] Upgrade http(s)-proxy-agent#28563
Merged
Merged
Conversation
mpodwysocki
requested review from
ckairen,
deyaaeldeen,
jeremymeng,
timovv and
xirzec
as code owners
jeremymeng
approved these changes
Feb 13, 2024
Member
jeremymeng
left a comment
jeremymeng
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the fix!
Collaborator
|
API change check API changes are not detected in this pull request. |
This was referenced Feb 13, 2024
xirzec
added a commit
that referenced
this pull request
Mar 19, 2024
…red (#28974) ### Packages impacted by this PR `@azure/core-rest-pipeline` ### Issues associated with this PR #28951 ### Describe the problem that is addressed by this PR When PR #28563 upgraded `http-proxy-agent` it didn't properly pass along `port` as this is now encoded in the proxy URL instead of the agent options. This PR trims down the unnecessary parsing we are doing to turn the proxy URL into `ProxySettings`, preferring to pass the URL as-is to `http-proxy-agent` and avoid losing information. In cases where we receive `ProxySettings` we will convert it into a URL correctly. For unknown historical reasons, `getDefaultProxySettings` was exposed as public surface, but since we no longer need this internally, I have marked it as deprecated so we may remove it in a later major version. ### Are there test cases added in this PR? _(If not, why?)_ Existing tests were updated to validate the proxy URL being set correctly on the agent itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Upgrades to the 7.x version of the
https-proxy-agentandhttp-proxy-agentused for our proxy pipelines.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists