Skip to content

[eslint-plugin-azure-sdk] Move from Mocha to Vitest #28969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpodwysocki merged 5 commits into from
Mar 20, 2024
Merged

[eslint-plugin-azure-sdk] Move from Mocha to Vitest #28969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b1b36c6
[eslint] move to vitest
mpodwysocki Mar 19, 2024
1cf87df
[eslint] move to vitest
mpodwysocki Mar 19, 2024
a83045e
[eslint] move to vitest
mpodwysocki Mar 19, 2024
fc9e0a2
[eslint] update from main
mpodwysocki Mar 20, 2024
34643bf
[eslint] update from main
mpodwysocki Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
294 changes: 290 additions & 4 deletions common/config/rush/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions common/tools/eslint-plugin-azure-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"integration-test:browser": "echo skipped",
"integration-test:node": "echo skipped",
"integration-test": "npm run integration-test:node && npm run integration-test:browser",
"unit-test:node": "mocha --require source-map-support/register --require ts-node/register --timeout 10000 --full-trace tests/**/*.ts",
"unit-test:node": "cross-env VITE_CJS_IGNORE_WARNING=true vitest",
Copy link
Copy Markdown
Member

@maorleger maorleger Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to know why we're seeing this warning? The linked page has some debugging tricks like running with VITE_CJS_TRACE

I have not tried any of it yet, mostly just curious if we can avoid this env var (and the dependency on cross-env) with a small tweak somewhere

Copy link
Copy Markdown
Contributor Author

@mpodwysocki mpodwysocki Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maorleger we are seeing these because the CJS support for vite as noted here

"unit-test:browser": "echo skipped",
"unit-test": "npm run unit-test:node && npm run unit-test:browser",
"test": "npm run clean && npm run build:test && npm run unit-test"
Expand All @@ -60,6 +60,7 @@
},
"prettier": "./prettier.json",
"peerDependencies": {
"@eslint/eslintrc": "^3.0.2",
"@typescript-eslint/eslint-plugin": "~5.57.0",
"@typescript-eslint/parser": "~5.57.0",
"eslint": "^8.50.0",
Expand All @@ -76,24 +77,23 @@
"glob": "^9.0.0",
"json-schema": "^0.4.0",
"typescript": "~5.3.3",
"tslib": "^2.2.0"
"tslib": "^2.6.2"
},
"devDependencies": {
"@types/chai": "^4.1.6",
"@types/json-schema": "^7.0.6",
"@types/mocha": "^10.0.0",
"@types/node": "^18.0.0",
"@typescript-eslint/eslint-plugin": "~5.57.0",
"@typescript-eslint/experimental-utils": "~5.57.0",
"@typescript-eslint/parser": "~5.57.0",
"chai": "^4.2.0",
"@typescript-eslint/rule-tester": "^7.3.0",
"@vitest/coverage-istanbul": "^1.4.0",
"cross-env": "^7.0.3",
"eslint": "^8.50.0",
"mocha": "^10.0.0",
"eslint-plugin-markdown": "~3.0.0",
"prettier": "^3.2.5",
"rimraf": "^3.0.0",
"rimraf": "^5.0.5",
"source-map-support": "^0.5.9",
"typescript": "~5.3.3",
"eslint-plugin-markdown": "~3.0.0",
"ts-node": "^10.0.0"
"vitest": "^1.4.0"
}
}
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-name.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function getPackageMetadata(node: Property): {
const nodeValue = node.value as Literal;
const packageName = nodeValue.value as string;
// Check if there is a sub scope i.e @azure-rest
const [_, subScope] = packageName.match(/^@azure(-[a-z]+)?\//) ?? [];
const [, subScope] = packageName.match(/^@azure(-[a-z]+)?\//) ?? [];

return {
nodeValue,
Expand Down
3 changes: 1 addition & 2 deletions common/tools/eslint-plugin-azure-sdk/tests/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
* @author Arpan Laha
*/

import { describe, it } from "mocha";
import { assert } from "chai";
import { describe, it, assert } from "vitest";
import plugin from "../src";

/**
Expand Down
14 changes: 14 additions & 0 deletions common/tools/eslint-plugin-azure-sdk/tests/ruleTester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

import * as vitest from "vitest";
import { RuleTester } from "@typescript-eslint/rule-tester";

RuleTester.afterAll = vitest.afterAll;

// If you are not using vitest with globals: true (https://vitest.dev/config/#globals):
RuleTester.it = vitest.it;
RuleTester.itOnly = vitest.it.only;
RuleTester.describe = vitest.describe;

export { RuleTester };
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/github-source-headers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/github-source-headers";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-apiextractor-json-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @author Will Temple
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-apiextractor-json-types";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-apisurface-standardized-verbs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-apisurface-standardized-verbs";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-apisurface-supportcancellation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-apisurface-supportcancellation";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-config-include.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Wei Jun Tan
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-config-include";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-doc-internal-private-member.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Hamsa Shankar
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-doc-internal-private-member";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-doc-internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-doc-internal";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-error-handling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-error-handling";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-modules-only-named.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-modules-only-named";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-naming-drop-noun.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-naming-drop-noun";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-naming-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-naming-options";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-naming-subclients.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-naming-subclients";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-no-const-enums.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-no-const-enums";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-no-window.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Maor Leger
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-no-window";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-author.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-author";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-bugs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-bugs";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-engine-is-present.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

"use strict";

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule, { LTS } from "../../src/rules/ts-package-json-engine-is-present";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-files-required.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-files-required";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-homepage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-homepage";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-keywords.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-keywords";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-license.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-license";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-main-is-cjs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-main-is-cjs";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-module";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-name.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-name";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-repo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-repo";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-required-scripts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-required-scripts";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-sdktype.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Ben Zhang
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-sdktype";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-sideeffects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-sideeffects";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-package-json-types";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-pagination-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-pagination-list";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-use-interface-parameters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-use-interface-parameters";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-use-promises.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-use-promises";

//------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/rules/ts-versioning-semver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @author Arpan Laha
*/

import { RuleTester } from "eslint";
import { RuleTester } from "../ruleTester";
import rule from "../../src/rules/ts-versioning-semver";

//------------------------------------------------------------------------------
Expand Down
Loading