[eslint-plugin-azure-sdk] Move from Mocha to Vitest#28969
Merged
Conversation
mpodwysocki
requested review from
ckairen,
deyaaeldeen,
jeremymeng and
mikeharder
as code owners
maorleger
approved these changes
Mar 20, 2024
| "integration-test:node": "echo skipped", | ||
| "integration-test": "npm run integration-test:node && npm run integration-test:browser", | ||
| "unit-test:node": "mocha --require source-map-support/register --require ts-node/register --timeout 10000 --full-trace tests/**/*.ts", | ||
| "unit-test:node": "cross-env VITE_CJS_IGNORE_WARNING=true vitest", |
Member
There was a problem hiding this comment.
Do you happen to know why we're seeing this warning? The linked page has some debugging tricks like running with VITE_CJS_TRACE
I have not tried any of it yet, mostly just curious if we can avoid this env var (and the dependency on cross-env) with a small tweak somewhere
Contributor
Author
There was a problem hiding this comment.
@maorleger we are seeing these because the CJS support for vite as noted here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Moves from
mochatovitestforeslint.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists