Merged
Conversation
github-actions
bot
added
Cognitive - Language
Event Hubs
KeyVault
Schema Registry
WebPubSub
labels
Collaborator
|
API change check API changes are not detected in this pull request. |
maorleger
requested review from
ckairen,
deyaaeldeen,
mikeharder,
minhanh-phan,
quentinRobinson,
timovv and
vicancy
as code owners
maorleger
commented
Mar 8, 2024
Member
|
@maorleger can you merge main? |
maorleger
commented
Mar 11, 2024
maorleger
force-pushed
the
remove-use-esm-workaround
branch
from
60a10ae to
49d0af3
Compare
maorleger
requested review from
a team,
hectorhdzg,
lmolkova and
srnagar
as code owners
maorleger
requested review from
KarishmaGhiya,
gracewilcox,
jairmyree,
joshfree,
nisha-bhatia,
pvaneck and
scottaddie
xirzec
approved these changes
Mar 12, 2024
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
Nice! Assuming this pleases CI, I think we should be good to go.
Member
|
/azp run js - ai-document-intelligence-rest - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
min/max is failing because it does not use dev-tool commands today https://github.com/maorleger/azure-sdk-for-js/blob/main/eng/tools/dependency-testing/templates/package.json#L12 We should update that as well, but in a separate PR given the number of checks already run on this PR (opened #28890) |
Member
|
/check-enforcer override |
Member
Author
|
/azp run js - identity - tests Edit: want to see if identity nightly tests are fixed by this as well.. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maorleger
added a commit
that referenced
this pull request
Mar 12, 2024
### Packages impacted by this PR N/A ### Issues associated with this PR Build failures ### Describe the problem that is addressed by this PR `esm` is slowly becoming a larger problem for us and we've been on a mission to remove it. min/max tests fail because esm is unable to handle safe-navigation operators (?.) While a separate PR switches tests to use tsx, this PR focuses on min/max tests and can be merged separately. ### Provide a list of related PRs _(if any)_ #28826
Member
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds off of Matt's work on moving to tsx in #28801 by removing the
use-esm-workaroundflag from packagesthat needed it before we moved to tsx.
There's additional cleanup to be had, but I am trying not to cause a build storm.
We are at a point where we can delete
esmglobally!Contributes to #28617 which can be completed with a no-ci change to remove
esmglobally