-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test networkanalytics generation with modular #28812
Conversation
sdk/networkanalytics/arm-networkanalytics/test/networkanalytics_operations_test.spec.ts
Outdated
Show resolved
Hide resolved
@@ -1,15 +0,0 @@ | |||
# Release History | |||
|
|||
## 1.0.1 (Unreleased) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use the hlc-code-gen change log tool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
// @public | ||
export type CreatedByType = string; | ||
export type createdByType = string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why lower case: createdByType?
export interface ArmResource extends ArmResourceBase { | ||
readonly id: string; | ||
readonly systemData?: SystemData; | ||
readonly type: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wired readonly with required info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sdk/networkanalytics/arm-networkanalytics/test/networkanalytics_operations_test.spec.ts
Outdated
Show resolved
Hide resolved
assert.equal(res.name, resourcename); | ||
}, | ||
id: "", | ||
type: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this because of readonly required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
location, | ||
properties: { | ||
majorVersion: "1", | ||
product: "MCC", | ||
publisher: "Microsoft" | ||
} | ||
}, | ||
testPollingOptions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we set this option in new code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not available for non-lro operation
// @public | ||
export interface DataProductsRemoveUserRoleOptionalParams extends coreClient.OperationOptions { | ||
// @public (undocumented) | ||
export interface DataProductsOperations { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you change manually from DataProductsOperations to DataProducts? so we could better find the gaps.
@@ -311,15 +258,15 @@ export interface DataProductUpdateProperties { | |||
} | |||
|
|||
// @public | |||
export type DataProductUserRole = string; | |||
export type DataProductUserRole = string | "Reader" | "SensitiveReader"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we have this gap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current code in swagger https://github.com/Azure/azure-rest-api-specs/blob/main/specification/networkanalytics/resource-manager/Microsoft.NetworkAnalytics/stable/2023-11-15/networkanalytics.json
current code in sdk:
/** Known values of {@link DataProductUserRole} that the service accepts. */
export enum KnownDataProductUserRole {
/** Field to specify user of type Reader. */
Reader = "Reader",
/**
* Field to specify user of type SensitiveReader.
* This user has privileged access to read sensitive data of a data product.
*/
SensitiveReader = "SensitiveReader"
}
/**
* Defines values for DataProductUserRole. \
* {@link KnownDataProductUserRole} can be used interchangeably with DataProductUserRole,
* this enum contains the known values that the service supports.
* ### Known values supported by the service
* **Reader**: Field to specify user of type Reader. \
* **SensitiveReader**: Field to specify user of type SensitiveReader.
* This user has privileged access to read sensitive data of a data product.
*/
export type DataProductUserRole = string;
}, | ||
credentials: { | ||
scopes: options.credentials?.scopes ?? ["user_impersonation"], | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong scope setting here.
No description provided.