Mitigate gaps for common types between swagger and typespec

[MaryGao]

No description provided.

[kazrael2119]

1. model name changed:
   TrackedResource->TrackedResourceBase
   Resource->ArmResource
   ProxyResource->ProxyResourceBase
   same issue with resource model changes of generated SDK code based on TSP compared with swagger typespec-azure#104

2. model name chagned:
   ManagedServiceIdentity->ManagedIdentityProperties
   ManagedServiceIdentityType->ManagedIdentityType
   same issue with [Bug] ManagedServiceIdentityType enum name is different between TSP and Swagger typespec-azure#278

3. remove parameter name under ArmResource
   in swagger , it has name https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/types.json#L20
   but in tsp, it doesn't have it https://github.com/Azure/typespec-azure/blob/50e384ce1b0597035b819c9370b1cc8545dafbbe/packages/typespec-azure-resource-manager/lib/arm.foundations.tsp#L23
   same issue with Discrepancy of generation from tsp and swagger for resource name property typespec-azure#378

4. removed model ErrorResponse

5. type of createdByType in SystemData under swagger common model has modelAsStringhttps://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/types.json#L502-L524
   in tsp , it only a string https://github.com/Azure/typespec-azure/blob/main/packages/typespec-azure-resource-manager/lib/arm.foundations.tsp#L313-L325

6. in swagger, parameter id, type from Resource are optional and readonly https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/types.json#L14-L29
   in tsp, id, type from ArmResource are required but readonly https://github.com/Azure/typespec-azure/blob/main/packages/typespec-azure-resource-manager/lib/arm.foundations.tsp#L23-L32

[MaryGao]

For 1, 2, 3 we have issues tracked.

For 4 this is introduced by design because we move ErrorResponse to core.

For 5 both are modeled as extensible enum but modular name is createdByType but hlc is CreatedByType(normailized).

[MaryGao]

For 6 in swagger we could specify the required or optional in required section so the subtypes could change the parent's optionality. but in typespec we can't do that. we would always inheritant this from parent's definition. We may need the tsp team's help to resolve this and issue is tracked here.

For example the DataProduct type didn't specify any required properties in swagger. So all properties are optional.

In typespec the id and type are required by default so the type DataProduct would have them as required https://github.com/Azure/azure-sdk-for-js/pull/28812/files#r1519701904.

[MaryGao]

but in typespec we can't do that

One workaround is to override the definition in sub types. tracked here: Azure/typespec-azure#401

[MaryGao]

Add HoldOn label cause we need tsp team to resolve common types' breakings.

[qiaozha]

need to upgrade the typespec compiler version and verify it.

[MaryGao]

Updated as May 20,

1. fixed
2. not verify
3. fixed
4. fixed
5. breaking is introduced by extensible enum design change and tracked here: [JS] Redesign Extensible Enum generation #2420
6. fixed
7. [New] @kazrael2119 could you verify this also? [TCGC] [ARM] Expected client code on definition model UserAssignedIdentities is Record<UserAssignedIdentity>;  typespec-azure#825

[kazrael2119]

Updated as May 20,

1. fixed
2. not verify
3. fixed
4. fixed
5. breaking is introduced by extensible enum design change and tracked here: [JS] Redesign Extensible Enum generation #2420
6. fixed
7. [New] @kazrael2119 could you verify this also? [TCGC] [ARM] Expected client code on definition model UserAssignedIdentities is Record<UserAssignedIdentity>;  typespec-azure#825

2 fixed

7 not a breaking in JS

[MaryGao]

Close this one considering there is no breaking introduced by common types.

[MaryGao]

the item 7 is tracked here #2535