[mgmt] netapp release#28048
Merged
Merged
Conversation
kazrael2119
requested review from
MaryGao,
ckairen,
deyaaeldeen,
jeremymeng,
qiaozha and
witemple-msft
as code owners
github-actions
Bot
added
the
Mgmt
Member
Author
|
breaking caused by Azure/azure-rest-api-specs#26643 |
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
qiaozha
reviewed
Dec 18, 2023
| @@ -1091,8 +1207,6 @@ export interface VolumeGroupMetaData { | |||
| applicationIdentifier?: string; | |||
| /** Application specific placement rules for the volume group */ | |||
| globalPlacementRules?: PlacementKeyValuePairs[]; | |||
| /** Application specific identifier of deployment rules for the volume group */ | |||
| deploymentSpecId?: string; | |||
Member
There was a problem hiding this comment.
Can you show me the link where this breaking has been approved in api layer ? Thanks
Member
Author
qiaozha
reviewed
Dec 18, 2023
| - Type of parameter userAssignedIdentities of interface ManagedServiceIdentity is changed from { | ||
| [propertyName: string]: UserAssignedIdentity; | ||
| } to { | ||
| [propertyName: string]: UserAssignedIdentity | null; |
Member
There was a problem hiding this comment.
Could you also find the swagger change that is related to this change ? Thanks
qiaozha
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/4816